-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LowerExp
and UpperExp
implementations to NonZero
#458
Labels
ACP-accepted
API Change Proposal is accepted (seconded with no objections)
api-change-proposal
A proposal to add or alter unstable APIs in the standard libraries
T-libs-api
Comments
rick-de-water
added
api-change-proposal
A proposal to add or alter unstable APIs in the standard libraries
T-libs-api
labels
Oct 7, 2024
Please send a PR. I agree this looks like an oversight from rust-lang/rust#48265. |
dtolnay
added
the
ACP-accepted
API Change Proposal is accepted (seconded with no objections)
label
Oct 7, 2024
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this issue
Nov 3, 2024
Add LowerExp and UpperExp implementations to NonZero Adds `LowerExp` and `UpperExp` trait implementations to `NonZero`, as discussed in rust-lang/libs-team#458. I had to modify the macro to mark the new impls with a different rust version. Let me know if this is the right way to do it (first timer here!)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Nov 3, 2024
Add LowerExp and UpperExp implementations to NonZero Adds `LowerExp` and `UpperExp` trait implementations to `NonZero`, as discussed in rust-lang/libs-team#458. I had to modify the macro to mark the new impls with a different rust version. Let me know if this is the right way to do it (first timer here!)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Nov 3, 2024
Add LowerExp and UpperExp implementations to NonZero Adds `LowerExp` and `UpperExp` trait implementations to `NonZero`, as discussed in rust-lang/libs-team#458. I had to modify the macro to mark the new impls with a different rust version. Let me know if this is the right way to do it (first timer here!)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Nov 3, 2024
Rollup merge of rust-lang#131377 - rick-de-water:nonzero-exp, r=dtolnay Add LowerExp and UpperExp implementations to NonZero Adds `LowerExp` and `UpperExp` trait implementations to `NonZero`, as discussed in rust-lang/libs-team#458. I had to modify the macro to mark the new impls with a different rust version. Let me know if this is the right way to do it (first timer here!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ACP-accepted
API Change Proposal is accepted (seconded with no objections)
api-change-proposal
A proposal to add or alter unstable APIs in the standard libraries
T-libs-api
Proposal
Problem statement
LowerExp
andUpperExp
format traits implementations are missing from theNonZero
integer types. All other (Binary
,*Hex
,Octal
, etc) have been implemented, so it looks like an oversight, especially since the integer primitives themselves do implementLowerExp
andUpperExp
.Motivating examples or use cases
UpperExp
example changed to useNonZeroU32
Solution sketch
Implement
LowerExp
andUpperExp
. It probably only involves addingimpl_nonzero_fmt!(LowerExp)
andimpl_nonzero_fmt!(UpperExp)
to the list of format implsAlternatives
Use
.get()
like a pleb, which then needs to be passed as an argument since you cannot call functions fromformat!
and friends.Links and related work
N/A
What happens now?
This issue contains an API change proposal (or ACP) and is part of the libs-api team feature lifecycle. Once this issue is filed, the libs-api team will review open proposals as capability becomes available. Current response times do not have a clear estimate, but may be up to several months.
Possible responses
The libs team may respond in various different ways. First, the team will consider the problem (this doesn't require any concrete solution or alternatives to have been proposed):
Second, if there's a concrete solution:
The text was updated successfully, but these errors were encountered: