Unix: Add _PATH_BSHELL and _PATH_DEFPATH where available

libc-test/build/main.rs

@@ -200,6 +200,7 @@ fn test_apple(t: &Target) {
         "os/lock.h",
         "os/signpost.h",
         "os/os_sync_wait_on_address.h",
+        "paths.h",
         "poll.h",
         "pthread.h",
         "pthread_spis.h",
@@ -473,6 +474,7 @@ fn test_openbsd(t: &Target) {
         "sys/shm.h",
         "sys/param.h",
         "sys/auxv.h",
+        "paths.h",
     );
 
     cfg.rename_type(|ty| match ty {
@@ -574,6 +576,7 @@ fn test_cygwin(t: &Target) {
         "net/if.h",
         "netdb.h",
         "netinet/tcp.h",
+        "paths.h",
         "poll.h",
         "pthread.h",
         "pty.h",
@@ -875,6 +878,7 @@ fn test_redox(t: &Target) {
         "netinet/in.h",
         "netinet/ip.h",
         "netinet/tcp.h",
+        "paths.h",
         "poll.h",
         "pwd.h",
         "semaphore.h",
@@ -1303,6 +1307,7 @@ fn test_netbsd(t: &Target) {
         "iconv.h",
         "utmp.h",
         "utmpx.h",
+        "paths.h",
     );
 
     cfg.rename_type(move |ty| {
@@ -1546,6 +1551,7 @@ fn test_dragonflybsd(t: &Target) {
         "netinet/ip.h",
         "netinet/tcp.h",
         "netinet/udp.h",
+        "paths.h",
         "poll.h",
         "pthread.h",
         "pthread_np.h",
@@ -2077,6 +2083,7 @@ fn test_android(t: &Target) {
         // generate the error 'Your time_t is already 64-bit'
         (t.p32(), "time64.h"),
         (x86, "sys/reg.h"),
+        "paths.h",
     );
 
     // Include linux headers at the end:
@@ -2560,6 +2567,7 @@ fn test_freebsd(t: &Target) {
         "netinet/tcp.h",
         "netinet/udp.h",
         "netinet6/in6_var.h",
+        "paths.h",
         "poll.h",
         "pthread.h",
         "pthread_np.h",
@@ -3247,6 +3255,7 @@ fn test_emscripten(t: &Target) {
         "utmp.h",
         "utmpx.h",
         "wchar.h",
+        "paths.h",
     );
 
     cfg.rename_struct_ty(move |ty| {
@@ -4106,6 +4115,7 @@ fn test_linux(t: &Target) {
         // https://www.openwall.com/lists/musl/2015/04/09/3
         // <execinfo.h> is not present on uclibc.
         (!(musl || uclibc), "execinfo.h"),
+        "paths.h",
     );
 
     // Include linux headers at the end:
@@ -5494,6 +5504,7 @@ fn test_haiku(t: &Target) {
         "netinet6/in6.h",
         "nl_types.h",
         "null.h",
+        "paths.h",
         "poll.h",
         "pthread.h",
         "pwd.h",

libc-test/semver/android.txt

@@ -3175,6 +3175,8 @@ X_OK
 _IOFBF
 _IOLBF
 _IONBF
+_PATH_BSHELL
+_PATH_DEFPATH
 _PC_2_SYMLINKS
 _PC_ALLOC_SIZE_MIN
 _PC_ASYNC_IO

libc-test/semver/apple.txt

@@ -1627,6 +1627,8 @@ _NSGetArgc
 _NSGetArgv
 _NSGetEnviron
 _NSGetProgname
+_PATH_BSHELL
+_PATH_DEFPATH
 _PC_2_SYMLINKS
 _PC_ALLOC_SIZE_MIN
 _PC_ASYNC_IO

libc-test/semver/cygwin.txt

@@ -472,6 +472,8 @@ WINDOWS_SEND
 XTABS
 _CS_PATH
 _IONBF
+_PATH_BSHELL
+_PATH_DEFPATH
 _PC_2_SYMLINKS
 _PC_ALLOC_SIZE_MIN
 _PC_ASYNC_IO

libc-test/semver/dragonfly.txt

@@ -1171,6 +1171,8 @@ _CS_PATH
 _IOFBF
 _IOLBF
 _IONBF
+_PATH_BSHELL
+_PATH_DEFPATH
 _PC_2_SYMLINKS
 _PC_ACL_EXTENDED
 _PC_ACL_PATH_MAX

libc-test/semver/espidf.txt

@@ -32,6 +32,7 @@ SIGSEGV
 SIGTERM
 SOL_SOCKET
 SOMAXCONN
+_PATH_BSHELL
 __errno
 cmsghdr
 dirent

libc-test/semver/freebsd.txt

@@ -1766,6 +1766,8 @@ _IOR
 _IOW
 _IOWINT
 _IOWR
+_PATH_BSHELL
+_PATH_DEFPATH
 _PC_ACL_EXTENDED
 _PC_ACL_NFS4
 _PC_ACL_PATH_MAX

libc-test/semver/linux.txt

@@ -3873,6 +3873,8 @@ _IONBF
 _IOR
 _IOW
 _IOWR
+_PATH_BSHELL
+_PATH_DEFPATH
 _PC_2_SYMLINKS
 _PC_ALLOC_SIZE_MIN
 _PC_ASYNC_IO

libc-test/semver/netbsd.txt

@@ -1127,6 +1127,8 @@ _IONBF
 _IOR
 _IOW
 _IOWR
+_PATH_BSHELL
+_PATH_DEFPATH
 _PC_2_SYMLINKS
 _PC_ACL_EXTENDED
 _PC_FILESIZEBITS

libc-test/semver/openbsd.txt

@@ -985,6 +985,8 @@ _IOR
 _IOW
 _IOWR
 _MAX_PAGE_SHIFT
+_PATH_BSHELL
+_PATH_DEFPATH
 _PC_2_SYMLINKS
 _PC_ALLOC_SIZE_MIN
 _PC_ASYNC_IO

libc-test/semver/redox.txt

@@ -258,6 +258,7 @@ _CS_POSIX_V7_WIDTH_RESTRICTED_ENVS
 _IOFBF
 _IOLBF
 _IONBF
+_PATH_BSHELL
 _PC_2_SYMLINKS
 _PC_ALLOC_SIZE_MIN
 _PC_ASYNC_IO

src/types.rs

@@ -138,3 +138,11 @@ pub const fn replace_array_items<T: Copy, const N: usize>(
     }
     dst
 }
+
+/// Constructs a compile time cstring literal from a byte array
+// FIXME(msrv): we can opt to use C-string literals directly in 1.77
+#[allow(unused)]
+pub(crate) const fn cstr(bytes: &[u8]) -> *const c_char {
+    assert!(!bytes.is_empty() && bytes[bytes.len() - 1] == 0);
+    bytes.as_ptr().cast::<i8>()
+}

src/unix/bsd/apple/mod.rs

@@ -3,6 +3,7 @@
 //! This covers *-apple-* triples currently
 
 use crate::prelude::*;
+use crate::types::cstr;
 use crate::{
     cmsghdr,
     off_t,
@@ -4111,6 +4112,9 @@ pub const VMADDR_CID_RESERVED: c_uint = 1;
 pub const VMADDR_CID_HOST: c_uint = 2;
 pub const VMADDR_PORT_ANY: c_uint = 0xFFFFFFFF;
 
+// include/paths.h
+const _PATH_DEFPATH: *const c_char = cstr(b"/usr/bin:/bin\0");
+
 const fn __DARWIN_ALIGN32(p: usize) -> usize {
     const __DARWIN_ALIGNBYTES32: usize = size_of::<u32>() - 1;
     (p + __DARWIN_ALIGNBYTES32) & !__DARWIN_ALIGNBYTES32

src/unix/bsd/freebsdlike/dragonfly/mod.rs

@@ -1,4 +1,5 @@
 use crate::prelude::*;
+use crate::types::cstr;
 use crate::{
     cmsghdr,
     off_t,
@@ -1232,6 +1233,11 @@ pub const RTAX_MPLS3: c_int = 10;
 /// for details.
 pub const RTAX_MAX: c_int = 11;
 
+// include/paths.h
+const _PATH_DEFPATH: *const c_char = cstr(
+    b"/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin:/usr/pkg/bin:/usr/pkg/sbin\0",
+);
+
 const fn _CMSG_ALIGN(n: usize) -> usize {
     (n + (size_of::<c_long>() - 1)) & !(size_of::<c_long>() - 1)
 }

src/unix/bsd/freebsdlike/freebsd/mod.rs

@@ -1,4 +1,5 @@
 use crate::prelude::*;
+use crate::types::cstr;
 use crate::{
     cmsghdr,
     off_t,
@@ -4318,6 +4319,10 @@ const fn _ALIGN(p: usize) -> usize {
     (p + _ALIGNBYTES) & !_ALIGNBYTES
 }
 
+// include/paths.h
+const _PATH_DEFPATH: *const c_char =
+    cstr(b"/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin\0");
+
 f! {
     pub unsafe fn CMSG_DATA(cmsg: *const cmsghdr) -> *mut c_uchar {
         (cmsg as *mut c_uchar).add(_ALIGN(size_of::<cmsghdr>()))

src/unix/bsd/mod.rs

@@ -1,4 +1,5 @@
 use crate::prelude::*;
+use crate::types::cstr;
 
 pub type off_t = i64;
 pub type useconds_t = u32;
@@ -480,6 +481,9 @@ cfg_if! {
     }
 }
 
+// include/paths.h
+pub const _PATH_BSHELL: *const c_char = cstr(b"/bin/sh\0");
+
 f! {
     pub unsafe fn CMSG_FIRSTHDR(mhdr: *const crate::msghdr) -> *mut cmsghdr {
         if (*mhdr).msg_controllen as usize >= size_of::<cmsghdr>() {

src/unix/bsd/netbsdlike/netbsd/mod.rs

@@ -1,4 +1,5 @@
 use crate::prelude::*;
+use crate::types::cstr;
 use crate::{
     cmsghdr,
     cpuid_t,
@@ -1813,6 +1814,9 @@ const fn _ALIGN(p: usize) -> usize {
     (p + _ALIGNBYTES) & !_ALIGNBYTES
 }
 
+// include/paths.h
+const _PATH_DEFPATH: *const c_char = cstr(b"/usr/bin:/bin:/usr/pkg/bin:/usr/local/bin\0");
+
 f! {
     pub unsafe fn CMSG_DATA(cmsg: *const cmsghdr) -> *mut c_uchar {
         (cmsg as *mut c_uchar).add(_ALIGN(size_of::<cmsghdr>()))

src/unix/bsd/netbsdlike/openbsd/mod.rs

@@ -1,4 +1,5 @@
 use crate::prelude::*;
+use crate::types::cstr;
 use crate::unix::bsd::O_SYNC;
 use crate::{
     cmsghdr,
@@ -1831,6 +1832,10 @@ const fn _ALIGN(p: usize) -> usize {
     (p + _ALIGNBYTES) & !_ALIGNBYTES
 }
 
+// include/paths.h
+const _PATH_DEFPATH: *const c_char =
+    cstr(b"/usr/bin:/bin:/usr/sbin:/sbin:/usr/X11R6/bin:/usr/local/bin:/usr/local/sbin\0");
+
 f! {
     pub unsafe fn CMSG_DATA(cmsg: *const cmsghdr) -> *mut c_uchar {
         (cmsg as *mut c_uchar).offset(_ALIGN(size_of::<cmsghdr>()) as isize)

src/unix/cygwin/mod.rs

@@ -1,4 +1,5 @@
 use crate::prelude::*;
+use crate::types::cstr;
 use crate::*;
 
 pub type wchar_t = c_ushort;
@@ -1678,6 +1679,12 @@ pub const FALLOC_FL_COLLAPSE_RANGE: c_int = 0x0008;
 pub const FALLOC_FL_INSERT_RANGE: c_int = 0x0010;
 pub const FALLOC_FL_KEEP_SIZE: c_int = 0x1000;
 
+// include/paths.h
+// Only defined in winsup/cygwin/include/paths.h
+pub const _PATH_DEFPATH: *const c_char = cstr(b"/bin\0");
+// This is defined in both winsup/cygwin/include/paths.h and newlib/libc/include/paths.h
+pub const _PATH_BSHELL: *const c_char = cstr(b"/bin/sh\0");
+
 f! {
     pub unsafe fn FD_CLR(fd: c_int, set: *mut fd_set) -> () {
         let fd = fd as usize;

src/unix/haiku/mod.rs

@@ -1,4 +1,5 @@
 use crate::prelude::*;
+use crate::types::cstr;
 
 // This module contains bindings to the native Haiku API. The Haiku API
 // originates from BeOS, and it was the original way to perform low level
@@ -1386,6 +1387,10 @@ pub const POSIX_SPAWN_SETSIGDEF: c_short = 0x10;
 pub const POSIX_SPAWN_SETSIGMASK: c_short = 0x20;
 pub const POSIX_SPAWN_SETSID: c_short = 0x40;
 
+// include/paths.h
+pub const _PATH_DEFPATH: *const c_char = cstr(b"/usr/bin:/bin\0");
+pub const _PATH_BSHELL: *const c_char = cstr(b"/bin/sh\0");
+
 const fn CMSG_ALIGN(len: usize) -> usize {
     len + size_of::<usize>() - 1 & !(size_of::<usize>() - 1)
 }

src/unix/linux_like/mod.rs

@@ -1,4 +1,5 @@
 use crate::prelude::*;
+use crate::types::cstr;
 
 pub type sa_family_t = u16;
 pub type speed_t = c_uint;
@@ -1497,6 +1498,28 @@ pub const ARPHRD_IEEE802154: u16 = 804;
 pub const ARPHRD_VOID: u16 = 0xFFFF;
 pub const ARPHRD_NONE: u16 = 0xFFFE;
 
+// include/paths.h
+cfg_if! {
+    if #[cfg(target_os = "android")] {
+        pub const _PATH_DEFPATH: *const c_char = cstr(b"/product/bin:/apex/com.android.runtime/bin:\
+        /apex/com.android.art/bin:/apex/com.android.virt/bin:/system_ext/bin:/system/bin:/system/xbin:\
+        /odm/bin:/vendor/bin:/vendor/xbin\0");
+        pub const _PATH_BSHELL: *const c_char = cstr(b"/system/bin/sh\0");
+    } else {
+        cfg_if! {
+            if #[cfg(any(target_env = "musl", target_env = "ohos"))] {
+                pub const _PATH_DEFPATH: *const c_char = cstr(b"/usr/local/bin:/bin:/usr/bin\0");
+            } else if #[cfg(any(target_env = "gnu", target_env = "uclibc"))] {
+                // pub const _PATH_DEFPATH: *const c_char = c"/usr/bin:/bin".as_ptr();
+                pub const _PATH_DEFPATH: *const c_char = cstr(b"/usr/bin:/bin\0");
+            } else {
+                // Unknown target_env
+            }
+        }
+        pub const _PATH_BSHELL: *const c_char = cstr(b"/bin/sh\0");
+    }
+}
+
 cfg_if! {
     if #[cfg(not(any(target_os = "emscripten", target_os = "l4re")))] {
         // linux/if_tun.h

src/unix/newlib/mod.rs

@@ -1,4 +1,5 @@
 use crate::prelude::*;
+use crate::types::cstr;
 
 pub type blkcnt_t = i32;
 pub type blksize_t = i32;
@@ -842,6 +843,9 @@ pub const PRIO_PROCESS: c_int = 0;
 pub const PRIO_PGRP: c_int = 1;
 pub const PRIO_USER: c_int = 2;
 
+// include/paths.h from newlib's libc
+pub const _PATH_BSHELL: *const c_char = cstr(b"/bin/sh\0");
+
 f! {
     pub unsafe fn FD_CLR(fd: c_int, set: *mut fd_set) -> () {
         let bits = size_of_val(&(*set).fds_bits[0]) * 8;

src/unix/redox/mod.rs

@@ -1,4 +1,5 @@
 use crate::prelude::*;
+use crate::types::cstr;
 
 pub type wchar_t = i32;
 
@@ -1102,6 +1103,9 @@ pub const PRIO_USER: c_int = 2;
 
 pub const RENAME_NOREPLACE: c_uint = 1;
 
+// include/paths.h from relibc
+pub const _PATH_BSHELL: *const c_char = cstr(b"/bin/sh\0");
+
 f! {
     //sys/socket.h
     pub const unsafe fn CMSG_ALIGN(len: size_t) -> size_t {