gnu: remove public configuration for file offset bits#5268
Merged
Conversation
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
tgross35
force-pushed
the
gnu-file-bits
branch
2 times, most recently
from
July 9, 2026 17:30
0540d5d to
3f5ef45
Compare
tgross35
changed the title
It makes sense for us to keep the internal config around for ease of matching source, but 64-bit off_t with 32-bit time_t is not a combination we need to support. This is the only option enabled by toggling _TIME_BITS and _FILE_OFFSET_BITS separately in glibc. Thus, remove `libc_unstable_gnu_file_offset_bits` but keep the internal `gnu_file_offset_bits64`. Closes: rust-lang#5199
tgross35
enabled auto-merge
July 9, 2026 17:34
tgross35
added
the
stable-nominated
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 20, 2026
It makes sense for us to keep the internal config around for ease of matching source, but 64-bit off_t with 32-bit time_t is not a combination we need to support. This is the only option enabled by toggling _TIME_BITS and _FILE_OFFSET_BITS separately in glibc. Thus, remove `libc_unstable_gnu_file_offset_bits` but keep the internal `gnu_file_offset_bits64`. Closes: rust-lang#5199 (backport <rust-lang#5268>) (cherry picked from commit 6a08ed3)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 20, 2026
It makes sense for us to keep the internal config around for ease of matching source, but 64-bit off_t with 32-bit time_t is not a combination we need to support. This is the only option enabled by toggling _TIME_BITS and _FILE_OFFSET_BITS separately in glibc. Thus, remove `libc_unstable_gnu_file_offset_bits` but keep the internal `gnu_file_offset_bits64`. Closes: rust-lang#5199 (backport <rust-lang#5268>) (cherry picked from commit 6a08ed3)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 20, 2026
It makes sense for us to keep the internal config around for ease of matching source, but 64-bit off_t with 32-bit time_t is not a combination we need to support. This is the only option enabled by toggling _TIME_BITS and _FILE_OFFSET_BITS separately in glibc. Thus, remove `libc_unstable_gnu_file_offset_bits` but keep the internal `gnu_file_offset_bits64`. Closes: rust-lang#5199 (backport <rust-lang#5268>) (cherry picked from commit 6a08ed3)
tgross35
added
stable-applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes sense for us to keep the internal config around for ease of
matching source, but 64-bit off_t with 32-bit time_t is not a
combination we need to support. This is the only option enabled by
toggling _TIME_BITS and _FILE_OFFSET_BITS separately in glibc.
Thus, remove
libc_unstable_gnu_file_offset_bitsbut keep the internalgnu_file_offset_bits64.Closes: #5199