Skip to content

Add solarish port_alert definitions#5203

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
psumbera:solaris-event_port
Jun 26, 2026
Merged

Add solarish port_alert definitions#5203
tgross35 merged 1 commit into
rust-lang:mainfrom
psumbera:solaris-event_port

Conversation

@psumbera

@psumbera psumbera commented Jun 23, 2026 •
edited by tgross35
Loading

Copy link
Copy Markdown
Contributor

@psumbera
Add solarish port_alert definitions
44dce71 
Add PORT_ALERT_* constants and the port_alert declaration shared by Solaris and illumos.
@rustbot

rustbot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in a solarish module

cc @jclulow, @pfmooney

@psumbera psumbera mentioned this pull request Jun 23, 2026
Merged
tgross35
tgross35 reviewed Jun 24, 2026
View reviewed changes

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but do you have a header or at least manpage you could link?

View changes since this review

@psumbera

psumbera commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Looks reasonable to me, but do you have a header or at least manpage you could link?

https://docs.oracle.com/cd/E88353_01/html/E37843/port-alert-3c.html

tgross35
tgross35 reviewed Jun 26, 2026
View reviewed changes
Comment thread src/unix/solarish/mod.rs
events: c_int,
user: *mut c_void,
) -> c_int;
pub fn port_alert(port: c_int, flags: c_int, events: c_int, user: *mut c_void) -> c_int;

@tgross35 tgross35 Jun 26, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm looking at the wrong thing, it seems like this definition should be Solaris-only since Illumos takes a struct pointer https://github.com/illumos/illumos-gate/blob/edd2f3461fcd719ff41d34b395ef3f5b5994fad1/usr/src/uts/common/fs/portfs/port.c#L453.

View changes since the review

@psumbera psumbera Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm looking at the wrong thing, it seems like this definition should be Solaris-only since Illumos takes a struct pointer https://github.com/illumos/illumos-gate/blob/edd2f3461fcd719ff41d34b395ef3f5b5994fad1/usr/src/uts/common/fs/portfs/port.c#L453.

No. It's the same as on Solaris:

https://github.com/illumos/illumos-gate/blob/edd2f3461fcd719ff41d34b395ef3f5b5994fad1/usr/src/head/port.h#L48

@tgross35 tgross35 Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thanks for the updated link. LGTM!

tgross35
tgross35 approved these changes Jun 26, 2026
View reviewed changes
Comment thread src/unix/solarish/mod.rs
events: c_int,
user: *mut c_void,
) -> c_int;
pub fn port_alert(port: c_int, flags: c_int, events: c_int, user: *mut c_void) -> c_int;

@tgross35 tgross35 Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thanks for the updated link. LGTM!

@tgross35
tgross35 added this pull request to the merge queue Jun 26, 2026
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jun 26, 2026
Merged via the queue into rust-lang:main with commit 465e736 Jun 26, 2026
54 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jul 20, 2026
@psumbera @tgross35
Add solarish port_alert definitions
79e2c0a 
Add PORT_ALERT_* constants and the port_alert declaration shared by Solaris and illumos.

(backport <rust-lang#5203>)
(cherry picked from commit 465e736)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jul 20, 2026
@psumbera @tgross35
Add solarish port_alert definitions
6b293c0 
Add PORT_ALERT_* constants and the port_alert declaration shared by Solaris and illumos.

(backport <rust-lang#5203>)
(cherry picked from commit 465e736)
This was referenced Jul 20, 2026
Merged
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jul 20, 2026
@psumbera @tgross35
Add solarish port_alert definitions
ead1369 
Add PORT_ALERT_* constants and the port_alert declaration shared by Solaris and illumos.

(backport <rust-lang#5203>)
(cherry picked from commit 465e736)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

No one assigned

Labels

stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@psumbera @rustbot @tgross35