Skip to content

FreeBSD: Replace unstable env to set version with an unstable cfg#5201

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
tgross35:freebsd-version-cfg
Jun 23, 2026
Merged

FreeBSD: Replace unstable env to set version with an unstable cfg#5201
tgross35 merged 1 commit into
rust-lang:mainfrom
tgross35:freebsd-version-cfg

Conversation

@tgross35

Copy link
Copy Markdown
Contributor

Environment variables affect builds for both the host and target, while cfg can be more accurately scoped with RUSTFLAGS.

@rustbot rustbot added the A-CI Area: CI-related items label Jun 23, 2026
@tgross35
tgross35 force-pushed the freebsd-version-cfg branch 6 times, most recently from 80f0644 to 7f917fc Compare June 23, 2026 04:10
@tgross35
tgross35 marked this pull request as ready for review June 23, 2026 04:14
@tgross35

Copy link
Copy Markdown
Contributor Author

Fyi @asomers, I'm planning to migrate env config to RUSTFLAGS. So if you are using RUST_LIBC_UNSTABLE_FREEBSD_VERSION=... anywhere outside of this repo's testing, it will need to be updated to --cfg=libc_unstable_freebsd_version="...".

@tgross35
tgross35 force-pushed the freebsd-version-cfg branch from 7f917fc to 4976da1 Compare June 23, 2026 04:19
@rustbot

This comment has been minimized.

Environment variables affect builds for both the host and target, while
cfg can be more accurately scoped with `RUSTFLAGS`.
@tgross35
tgross35 force-pushed the freebsd-version-cfg branch from 4976da1 to 5d40e5e Compare June 23, 2026 04:59
@rustbot

rustbot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tgross35
tgross35 added this pull request to the merge queue Jun 23, 2026
Merged via the queue into rust-lang:main with commit e3c4971 Jun 23, 2026
54 checks passed
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jun 23, 2026
@tgross35
tgross35 deleted the freebsd-version-cfg branch June 23, 2026 23:13
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Jul 20, 2026
Environment variables affect builds for both the host and target, while
cfg can be more accurately scoped with `RUSTFLAGS`.

(backport <rust-lang#5201>)
(cherry picked from commit e3c4971)
This was referenced Jul 20, 2026
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Jul 20, 2026
Environment variables affect builds for both the host and target, while
cfg can be more accurately scoped with `RUSTFLAGS`.

(backport <rust-lang#5201>)
(cherry picked from commit e3c4971)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: CI-related items stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants