Skip to content

newlib/espidf: Move DT_* to espidf/mod.rs#5034

Merged
tgross35 merged 1 commit intorust-lang:mainfrom
drinkcat:espidf-dt
Apr 1, 2026
Merged

newlib/espidf: Move DT_* to espidf/mod.rs#5034
tgross35 merged 1 commit intorust-lang:mainfrom
drinkcat:espidf-dt

Conversation

@drinkcat
Copy link
Copy Markdown
Contributor

@drinkcat drinkcat commented Mar 31, 2026

Description

The values for DT_* in espidf are different from standard newlib.

Detected using a fork of SergioGasquez/libc-checks: https://github.com/drinkcat/libc-checks/actions/runs/23748047229/job/69181969328

Sources

https://github.com/espressif/newlib-esp32/blob/67537d91e601c40e2b52b9b865518abb7eecc85b/newlib/libc/sys/esp/include/sys/dirent.h#L32

Checklist

  • Relevant tests in libc-test/semver have been updated => There are not new symbols, just renamed.
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI => Not applicable

@rustbot label +stable-nominated

@rustbot rustbot added S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Mar 31, 2026
The values are different from standard newlib.
Copy link
Copy Markdown
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgross35 tgross35 added this pull request to the merge queue Apr 1, 2026
Merged via the queue into rust-lang:main with commit 9c1167e Apr 1, 2026
51 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 1, 2026
The values are different from standard newlib.

(backport <rust-lang#5034>)
(cherry picked from commit 9c1167e)
@tgross35 tgross35 mentioned this pull request Apr 1, 2026
github-merge-queue bot pushed a commit that referenced this pull request Apr 1, 2026
The values are different from standard newlib.

(backport <#5034>)
(cherry picked from commit 9c1167e)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants