wasi: add all _SC_* sysconf constants from wasi-libc#5030
Closed
surban wants to merge 1 commit intorust-lang:libc-0.2from
Closed
wasi: add all _SC_* sysconf constants from wasi-libc#5030surban wants to merge 1 commit intorust-lang:libc-0.2from
surban wants to merge 1 commit intorust-lang:libc-0.2from
Conversation
Add the complete set of _SC_* constants from wasi-libc's musl-based unistd.h. (backport <rust-lang#5023>) (cherry picked from commit 2aa834e)
rustbot
added
S-waiting-on-review
stable-nominated
Collaborator
|
There was a problem hiding this comment.
Pull request overview
Adds the full set of POSIX _SC_* sysconf name constants for WASI targets, matching wasi-libc’s musl-derived unistd.h, and updates the semver surface test list accordingly.
Changes:
- Define the complete
_SC_*constant set insrc/wasi/mod.rs(including aliases like_SC_PAGE_SIZE). - Update
libc-test/semver/wasi.txtto include the newly exposed_SC_*symbols for semver checking.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/wasi/mod.rs |
Adds the missing _SC_* sysconf selector constants for WASI. |
libc-test/semver/wasi.txt |
Extends WASI semver API list to cover the new _SC_* exports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks! But we do backports when making a new release, your PR is labeled as |
tgross35
removed
the
stable-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the complete set of SC* constants from wasi-libc's musl-based unistd.h.
(backport #5023)
(cherry picked from commit 2aa834e)
@rustbot label +stable-nominated