Fix locale values and add RTLD_NOLOAD, and some TCP constants for Redox OS#5025
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Apr 1, 2026
Merged
Conversation
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
The changes look good, could squash commits into one? Also, we don't use copilot review in this repo, please refrain using it. |
Contributor
Author
|
Hi @JohnTitor, GitHub automatically enabled Copilot review without prior confirmation from me for all my PRs... I just turned it off, sorry about that. |
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
ChihweiLHBird
force-pushed
the
zhiwei/relibc-constants-update-2
branch
from
48a97b2 to
70051dc
Compare
Contributor
Author
|
All commits are combined now. Thanks for the review! |
tgross35
approved these changes
Apr 1, 2026
tgross35
added
the
stable-nominated
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Apr 1, 2026
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me> (backport <rust-lang#5025>) (cherry picked from commit 505ad34)
Merged
tgross35
added
stable-applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
LC_*locale constants, original values were copied from Linux, but Redox'srelibcuses a different numbering (LC_ALL=6instead of 0)RTLD_NOLOADfromdlfcn.hTCP_MAXSEG,TCP_KEEPINTVL,TCP_KEEPCNTfromnetinet/tcp.hSources
RTLD_NOLOADLC_COLLATEthroughLC_ALLTCP_MAXSEG,TCP_KEEPINTVL,TCP_KEEPCNTChecklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI