Skip to content

Conversation

@tinywombat765
Copy link
Contributor

I left in the comment from prctl.h I can remove them if you want.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Thanks for the PR! Looks like CI is failing due to line length limits, and yeah in general it's ok to remove comments from this library as this isn't really the authoritative source for how to use all these values.

@alexcrichton
Copy link
Member

Looks good to me, but looks like travis failures may be legitimate?

@tinywombat765
Copy link
Contributor Author

@alexcrichton Any idea how to fix the one that failed? I'm not sure why a few specific constants are having a problem on just android.

@alexcrichton
Copy link
Member

@zethra you can just move those constants down a level in the module hierarchy to the linux-specific module so they're not picked up on Android.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Dec 28, 2016

📌 Commit 1887630 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Dec 28, 2016

⌛ Testing commit 1887630 with merge 23e45ab...

bors added a commit that referenced this pull request Dec 28, 2016
Added constants from prctl.h

I left in the comment from prctl.h I can remove them if you want.
@bors
Copy link
Contributor

bors commented Dec 28, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 23e45ab to master...

@bors bors merged commit 1887630 into rust-lang:master Dec 28, 2016
Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants