Skip to content

Conversation

mkornaukhov
Copy link
Contributor

@mkornaukhov mkornaukhov commented Aug 20, 2025

Description

Add backtrace_symbols() and backtrace_symbols_fd() for linux gnu.
Fixes #4667

Sources

https://github.com/bminor/glibc/blob/6f999af332c91035350390ef8af96388b8f4fd2c/debug/execinfo.h

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot rustbot added O-gnu O-linux O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 20, 2025
@mkornaukhov mkornaukhov force-pushed the mkornaukhov03/extend-api-for-linux-gnu branch 3 times, most recently from 678e1de to ae90c2c Compare August 20, 2025 10:35
@mkornaukhov
Copy link
Contributor Author

The same pipelines are falling as on the main branch, I guess that means it's okay.
Waiting for review and merge

@mkornaukhov
Copy link
Contributor Author

@mbyx @tgross35 Hi!
Could you review this pull request please?

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, LGTM!

@tgross35 tgross35 added this pull request to the merge queue Sep 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Sep 1, 2025
@tgross35 tgross35 added this pull request to the merge queue Sep 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Sep 1, 2025
@tgross35
Copy link
Contributor

tgross35 commented Sep 1, 2025

@mkornaukhov03 could you please squash?

@mkornaukhov mkornaukhov force-pushed the mkornaukhov03/extend-api-for-linux-gnu branch from ae90c2c to 8654db3 Compare September 1, 2025 12:36
@mkornaukhov
Copy link
Contributor Author

@mkornaukhov03 could you please squash?

Done

@mkornaukhov
Copy link
Contributor Author

Sorry for the delay, LGTM!

Thank you for the feedback!
I've rebased and squashed.
Please, look at it again

@tgross35
Copy link
Contributor

tgross35 commented Sep 2, 2025

Thank you!

@tgross35 tgross35 added this pull request to the merge queue Sep 2, 2025
Merged via the queue into rust-lang:main with commit a69e346 Sep 2, 2025
51 of 52 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Sep 22, 2025
(backport <rust-lang#4668>)
(cherry picked from commit a69e346)
@tgross35 tgross35 mentioned this pull request Sep 22, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Sep 22, 2025
(backport <rust-lang#4668>)
(cherry picked from commit a69e346)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Sep 22, 2025
(backport <rust-lang#4668>)
(cherry picked from commit a69e346)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Sep 22, 2025
(backport <rust-lang#4668>)
(cherry picked from commit a69e346)
github-merge-queue bot pushed a commit that referenced this pull request Sep 22, 2025
(backport <#4668>)
(cherry picked from commit a69e346)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-gnu O-linux O-unix stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for backtrace_symbols_fd() on x86_64-unknown-linux-gnu
3 participants