Promote ctest-next to ctest
#4655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbyx
force-pushed
the
libc-promote-ctest-next
branch
from
68558dc to
b316b10
Compare
tgross35
reviewed
Aug 14, 2025
.github/workflows/ci.yaml
Outdated
Comment on lines
322
to
323
| - name: Remove edition 2024 crates | ||
| run: perl -i -ne 'print unless /"ctest-(next|test)",/ || /"libc-test",/' Cargo.toml | ||
| run: perl -i -ne 'print unless /"ctest(?:-test)?",/ || /"libc-test",/' Cargo.toml |
There was a problem hiding this comment.
Delete this bit now since the ctest-next msrv is the ctest msrv.
While you're here, could you rename this job from "Check MSRV" to "Check ctest MSRV"?
There was a problem hiding this comment.
The version of cargo the CI uses doesn't seem to support 2024 edition. EDIT: It seems that the command used for MSRV picks up the old ctest and not the new one since they have the same name.
mbyx
force-pushed
the
libc-promote-ctest-next
branch
from
b316b10 to
1637b76
Compare
mbyx
force-pushed
the
libc-promote-ctest-next
branch
3 times, most recently
from
be84053 to
28bf588
Compare
tgross35
reviewed
Aug 15, 2025
tgross35
reviewed
Aug 15, 2025
tgross35
reviewed
Aug 15, 2025
.github/workflows/ci.yaml
Outdated
Comment on lines
317
to
315
| msrv="$(cargo metadata --format-version 1 | jq -r --arg CRATE_NAME ctest '.packages | map(select(.name == $CRATE_NAME)) | first | .rust_version')" | ||
| msrv="$(cargo metadata --format-version 1 | jq -r --arg CRATE_NAME ctest '.packages | map(select(.name == $CRATE_NAME)) | last | .rust_version')" |
There was a problem hiding this comment.
The ordering of the packages isn't guaranteed, so this may not always work. You can grab only the local crate by changing the map(select(...)) query to add and (.id | startswith("path+file"))
If you could rewrap this a bit too that would be good, the line is pretty long already. (Bash should let you split lines anywhere within the $(...))
mbyx
force-pushed
the
libc-promote-ctest-next
branch
from
28bf588 to
c59da70
Compare
tgross35
reviewed
Aug 15, 2025
| license = "MIT OR Apache-2.0" | ||
| repository = "https://github.com/rust-lang/libc" | ||
| rust-version = "1.63.0" | ||
| publish = false |
There was a problem hiding this comment.
Ah autopublish failed, could you put up a PR to set this true? I'll get it later today if you're not active right now
tgross35
added
stable-unneeded
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 21, 2025
(backport <rust-lang#4655>) (cherry picked from commit b185a13)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 21, 2025
(backport <rust-lang#4655>) (cherry picked from commit b185a13)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 21, 2025
(backport <rust-lang#4655>) (cherry picked from commit b185a13)
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4655>) (cherry picked from commit b185a13)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4655>) (cherry picked from commit 4439546) [ drop everything related to the actual ctest-next impl - Trevor ]
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4655>) (cherry picked from commit 4439546) [ drop everything related to the actual ctest-next impl - Trevor ]
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4655>) (cherry picked from commit 4439546) [ drop everything related to the actual ctest-next impl. Some other Cargo.toml adjustments were needed. - Trevor ]
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4655>) (cherry picked from commit 4439546) [ drop everything related to the actual ctest-next impl. Some other Cargo.toml adjustments were needed. - Trevor ]
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4655>) (cherry picked from commit 4439546) [ drop everything related to the actual ctest-next impl. Some other Cargo.toml adjustments were needed. - Trevor ]
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Promotes
ctest-nextto be the newctest. Platforms not yet ported use the older version ofctestfrom crates.io asctest-old. Testing forctest-oldhas been removed fromctest-test.Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI