-
Notifications
You must be signed in to change notification settings - Fork 1.2k
s390x-linux-musl: remove bogus constants #4515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
musl-libc does not define RTLD_DEEPBIND on any architecture. Fixes: 88de388 ("add definitions for s390x musl targets")
musl-libc does not define O_FSYNC on any architecture, since commit v1.1.15-15-gc1f4ed15 (committed 2016-08-30): https://git.musl-libc.org/cgit/musl/commit/?id=c1f4ed150137d793c9d07356305a89e8785e7e02 Fixes: 88de388 ("add definitions for s390x musl targets")
Could you deprecate these rather than removing them? Obviously nobody should be using them, but we should give a bit of a migration path for anyone who isn't configuring these out on s390x. You can add a |
Sure, I'll deprecate them instead. What should I use as the version number for the
I'll do that. Thanks! |
This will get in the next release, which will be 0.2.175. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know what, I missed that this is the musl target which is tier 3. I think we can just go forward with what you have here.
musl-libc does not define RTLD_DEEPBIND on any architecture. Fixes: 88de388 ("add definitions for s390x musl targets") (backport <rust-lang#4515>) (cherry picked from commit 6faa6d3)
musl-libc does not define O_FSYNC on any architecture, since commit v1.1.15-15-gc1f4ed15 (committed 2016-08-30): https://git.musl-libc.org/cgit/musl/commit/?id=c1f4ed150137d793c9d07356305a89e8785e7e02 Fixes: 88de388 ("add definitions for s390x musl targets") (backport <rust-lang#4515>) (cherry picked from commit a5b89d3)
musl-libc does not define O_FSYNC on any architecture, since commit v1.1.15-15-gc1f4ed15 (committed 2016-08-30): https://git.musl-libc.org/cgit/musl/commit/?id=c1f4ed150137d793c9d07356305a89e8785e7e02 Fixes: 88de388 ("add definitions for s390x musl targets") (backport <#4515>) (cherry picked from commit a5b89d3)
Description
This change removes two constants from s390x.rs that are not present in musl-libc. This moves the
libc
testsuite closer to running successfully on s390x-linux-musl.Sources
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI