-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add klogctl
to linux and android
#3777
Add klogctl
to linux and android
#3777
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
@rustbot author |
3cdb3bd
to
da65e15
Compare
klogctl
to linux and android
Dear reviewer, some notes 🙂
CI seems to be green except for the MacOS runs. I did not touch anything MacOS-related, so I would guess the fails are unrelated. |
@rustbot review |
For android, we also add the `KLOG_*` constants. For linux, they are defined in source but not exported to user space.
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts. |
da65e15
to
ece907b
Compare
Thank you for the review @tgross35 ! I updated the argument name as suggested in your review. Next I changed the base of the PR to |
@rustbot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
For android, we also add the `KLOG_*` constants. For linux, they are defined in source but not exported to user space. (backport <rust-lang#3777>) (cherry picked from commit ece907b)
Those are useful to read the kernel message buffer.
References: