Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mkostemp, mkostemps on Android #3601

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Support mkostemp, mkostemps on Android #3601

merged 1 commit into from
Nov 20, 2024

Conversation

pcc
Copy link
Contributor

@pcc pcc commented Feb 28, 2024

@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@JohnTitor JohnTitor added this pull request to the merge queue Apr 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 29, 2024
@bors
Copy link
Contributor

bors commented Apr 29, 2024

☔ The latest upstream changes (presumably #3600) made this pull request unmergeable. Please resolve the merge conflicts.

@tgross35
Copy link
Contributor

@pcc can you rebase?

@rustbot author

@tgross35
Copy link
Contributor

@pcc ping, this should just need a rebase.

@pcc
Copy link
Contributor Author

pcc commented Nov 15, 2024

Rebased

tgross35
tgross35 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, the currently nightly doesn't build so I'll merge later.

Cc @maurer for Android

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 15, 2024
@tgross35
Copy link
Contributor

Wait sorry, this is targeting libc-0.2. @pcc can you please rebase onto main then change this PR's base branch?

@rustbot author

@tgross35 tgross35 added this pull request to the merge queue Nov 20, 2024
Merged via the queue into rust-lang:libc-0.2 with commit 46ebe26 Nov 20, 2024
45 checks passed
@tgross35 tgross35 added main-needs-cherry-pick This PR was merged against libc-0.2 but does not yet exist in main. and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 21, 2024
@andrewdavidmackenzie andrewdavidmackenzie mentioned this pull request Nov 26, 2024
Closed
@shadow3aaa shadow3aaa mentioned this pull request Dec 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@tgross35 tgross35 tgross35 approved these changes

Assignees

@JohnTitor JohnTitor

Labels
main-needs-cherry-pick This PR was merged against libc-0.2 but does not yet exist in main. O-linux O-linux-like O-unix S-waiting-on-author S-waiting-on-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pcc @rustbot @bors @tgross35 @JohnTitor