Skip to content

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented Feb 7, 2023

Thanks for considering submitting a PR!

Here's a checklist for things that will be checked during review or continuous integration.

  • Edit corresponding file(s) under libc-test/semver when you add/remove item(s)
  • rustc ci/style.rs && ./style src
  • cd libc-test && cargo test (This might fail on your env due to environment difference between your env and CI. Ignore failures if you are not sure.)
  • Your PR that bumps up the crate version doesn't contain any other changes

Delete this line and everything above before opening your PR.

@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@howjmay
Copy link
Contributor Author

howjmay commented Feb 7, 2023

@JohnTitor this is just a draft for solving #2962. May you give it a look. If the current way is ok. I will extend to other OS

@JohnTitor
Copy link
Member

Thanks for the PR!
The checklist above describes what we expect.
To simplify our review, I'd suggest you add only what you need. CI also should be fixed. Once it's done, I think we can r+ this PR.

@bors
Copy link
Contributor

bors commented Feb 12, 2023

☔ The latest upstream changes (presumably #3095) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnTitor
Copy link
Member

Triage: Closing as inactive, feel free to reopen/recreate if you're still interested in this change. Thanks for the PR anyway!

@JohnTitor JohnTitor closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants