freebsd proposal to move sockcred2 usage in the root mod while ignori… #2589
+26
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
devnexen
force-pushed
the
sockcred2_fbsd_fix_proposal
branch
3 times, most recently
from
a72a80d
to
9de7043
Compare
…ng it for FreeBSD 12.
devnexen
force-pushed
the
sockcred2_fbsd_fix_proposal
branch
from
9de7043
to
da089ce
Compare
| @@ -3701,6 +3712,15 @@ f! { | |||
| let (idx, offset) = (cpu / bitset_bits, cpu % bitset_bits); | |||
| 0 != cpuset.__bits[idx] & (1 << offset) | |||
| } | |||
|
|
|||
| pub fn SOCKCRED2SIZE(ngrps: usize) -> usize { | |||
There was a problem hiding this comment.
Won't it be an issue on freebsd 11 to link to a non-existing function?
GuillaumeGomez
approved these changes
Dec 12, 2021
|
Looks good to me since the struct has the same layout between 13 and 14 and the function is implemented, not linked. |
asomers
approved these changes
Dec 12, 2021
|
@bors r+ |
|
📌 Commit da089ce has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng it for FreeBSD 12.