Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freebsd 13 add copy_file_range api compatible with linux's glibc wrapper #2479

Merged
merged 1 commit into from
Oct 26, 2021
Merged

freebsd 13 add copy_file_range api compatible with linux's glibc wrapper #2479

merged 1 commit into from
Oct 26, 2021

Conversation

devnexen
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented Oct 26, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 26, 2021

📌 Commit 6276d19 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Oct 26, 2021

⌛ Testing commit 6276d19 with merge ba79bfa...

@bors
Copy link
Contributor

bors commented Oct 26, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing ba79bfa to master...

@bors bors merged commit ba79bfa into rust-lang:master Oct 26, 2021
asomers added a commit to asomers/libc that referenced this pull request Nov 30, 2022
PR rust-lang#2479 did this, but only in the freebsd13 and freebsd14 modules,
which was incorrect.  Those modules should only be used for functions
that change across FreeBSD versions, and therefore need different ELF
symbol versions.  Functions that were newly added since FreeBSD 11 can
still go in the base freebsd module.  It will cause no problems for them
to be there, and users will see an error at link time if they try to
use such a function in an environment that is too old to support it.
asomers added a commit to asomers/libc that referenced this pull request Nov 30, 2022
PR rust-lang#2479 did this, but only in the freebsd13 and freebsd14 modules,
which was incorrect.  Those modules should only be used for functions
that change across FreeBSD versions, and therefore need different ELF
symbol versions.  Functions that were newly added since FreeBSD 11 can
still go in the base freebsd module.  It will cause no problems for them
to be there, and users will see an error at link time if they try to
use such a function in an environment that is too old to support it.
bors added a commit that referenced this pull request Nov 30, 2022
Enable copy_file_range on FreeBSD

PR #2479 did this, but only in the freebsd13 and freebsd14 modules, which was incorrect.  Those modules should only be used for functions that change across FreeBSD versions, and therefore need different ELF symbol versions.  Functions that were newly added since FreeBSD 11 can still go in the base freebsd module.  It will cause no problems for them to be there, and users will see an error at link time if they try to use such a function in an environment that is too old to support it.
tatref pushed a commit to tatref/libc that referenced this pull request Mar 20, 2023
PR rust-lang#2479 did this, but only in the freebsd13 and freebsd14 modules,
which was incorrect.  Those modules should only be used for functions
that change across FreeBSD versions, and therefore need different ELF
symbol versions.  Functions that were newly added since FreeBSD 11 can
still go in the base freebsd module.  It will cause no problems for them
to be there, and users will see an error at link time if they try to
use such a function in an environment that is too old to support it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants