Remove link directives for libutil on linux-gnu targets #2046
+0
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are all handled in src/unix/mod.rs now, which also addresses the crt-static case; no linux-gnu target should have any link directives in any other module. This fixes static linking with glibc for various architectures.
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
|
r? @JohnTitor |
JohnTitor
approved these changes
Jan 28, 2021
|
@bors r+ |
|
📌 Commit 6859d47 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 28, 2021
Remove link directives for libutil on linux-gnu targets These are all handled in src/unix/mod.rs now, which also addresses the crt-static case; no linux-gnu target should have any link directives in any other module. This fixes static linking with glibc for various architectures.
|
💔 Test failed - checks-actions |
|
Failure looks like a transient network issue. Retrying. @bors retry |
|
Looks like we're now hitting rust-lang/cargo#9101 , which was caused by a change in serde. |
|
#2048 should fix the CI issue. |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all handled in src/unix/mod.rs now, which also addresses the
crt-static case; no linux-gnu target should have any link directives in
any other module.
This fixes static linking with glibc for various architectures.
Fixes #2033