Add definitions in ucontext.h in Android for ARM, x86, and x86_64 #1622

igrep · 2019-12-12T02:05:21Z

Ref: https://android.googlesource.com/platform/bionic/+/refs/tags/ndk-r20/libc/include/sys/ucontext.h

Will close #1604

rust-highfive · 2019-12-12T02:05:25Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

igrep · 2019-12-19T02:58:19Z

@gnzlbg This is a reminder. Now the left build error is just a network failure when building for nightly-x86_64-unknown-linux-gnu, which isn't modified by this pull request.
So there mustn't be any problems CI can detect.

gnzlbg

This looks really good already, i've left some minor comments.

src/unix/linux_like/android/b32/arm.rs

src/unix/linux_like/android/b64/mod.rs

src/unix/linux_like/android/b64/x86_64/mod.rs

igrep · 2019-12-24T00:23:54Z

All of your comments don't sound minor to me... 😂
Anyway, I'll fix as many as possible.
Thanks.

gnzlbg · 2019-12-24T08:38:40Z

Thank you for fixing all of these issues so quickly. I'll be a bit unavailable over christmas, but I'll try to take a look every now and then if you make progress with the types using an union.

Basically it' what you originally suggested: you need to create a named union, and then use it as a field. However, there is no union with that name in the C file, so you need to skip trying to generate tests for that in the libc-test/build.rs (e.g. by adding a match arm like: cfg.skip_struct(|name, is_struct, is_union| match name { ..., "your_union_name" if is_union => true, } ). This might not suffice, since then the struct has a field of the form field: your_union_name and there is no type your_union_name in C either, so we need to skip testing this struct field as well (there are examples in the libc-test/build.rs about how to do this).

I think it would be nice to have a way to test fields of anonymous unions by mapping them to some Rust union field in the ctest crate, but we don't have that functionality yet - so it's ok to skip these tests for now.

src/unix/linux_like/android/b32/arm.rs

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep · 2020-01-16T02:42:14Z

@gnzlbg Can you review again and merge?
The both of the last failures in CI are not related to my change (i686-apple-darwin and armv7-apple-ios)

https://dev.azure.com/rust-lang2/libc/_build/results?buildId=1075&view=logs&j=c7464085-50dc-55b0-d49a-ca2fc4e4d69e&t=7417e154-0538-5077-3a89-29444dec6e1c

https://dev.azure.com/rust-lang2/libc/_build/results?buildId=1075&view=logs&j=a0d58cc1-afb1-556c-24c8-109083aad81d&t=3a3b8099-ea38-5855-a2d4-9817ff96dcb5

I'll send a PR after rust-lang/libc#1622 is merged and released

rust-lang/libc#1622

igrep · 2020-01-30T05:04:03Z

@gnzlbg ping.

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep · 2020-02-19T04:06:32Z

@JohnTitor Can I ask you to review this instead of @gnzlbg?
This pull request has been stalled since I've fixed all problems pointed out...

JohnTitor · 2020-02-25T08:31:42Z

r? @JohnTitor

JohnTitor

Sorry for the delay! Overall looks good. Also could you squash commits into 5 or so? It's too large to merge just as it is.

src/unix/linux_like/android/b32/arm.rs

Ref: https://android.googlesource.com/platform/bionic/+/refs/tags/ndk-r20/libc/include/sys/ucontext.h

JohnTitor

Thanks!

I'll send a PR after rust-lang/libc#1622 is merged and released

The new version of libc contains changes necessary to build wasmer-runtime-core for Android. See rust-lang/libc#1622 for details.

1292: Experimental Support for Android (x86_64 and AArch64) r=syrusakbary a=igrep # Description Related: #1113 # Current Status - ~~This pull request is a draft until the next version of libc crate (which should contain rust-lang/libc#1622 - Now released! 🎉 - I confirmed the tests of wasmer-runtime-core pass on Android x86\_64. - The other tests including ones on AArch64 seems too hard so far... 😓 # Review - [x] Add a short description of the the change to the CHANGELOG.md file # Note I'm happy given any hint to test of Android specific code (esp. in libc I added in rust-lang/libc#1622). Co-authored-by: Yuji Yamamoto <[email protected]> Co-authored-by: YAMAMOTO Yuji <[email protected]>

I'll send a PR after rust-lang/libc#1622 is merged and released

The new version of libc contains changes necessary to build wasmer-runtime-core for Android. See rust-lang/libc#1622 for details.

1292: Experimental Support for Android (x86_64 and AArch64) r=syrusakbary a=igrep # Description Related: #1113 # Current Status - ~~This pull request is a draft until the next version of libc crate (which should contain rust-lang/libc#1622 - Now released! 🎉 - I confirmed the tests of wasmer-runtime-core pass on Android x86\_64. - The other tests including ones on AArch64 seems too hard so far... 😓 # Review - [x] Add a short description of the the change to the CHANGELOG.md file # Note I'm happy given any hint to test of Android specific code (esp. in libc I added in rust-lang/libc#1622). Co-authored-by: Yuji Yamamoto <[email protected]> Co-authored-by: YAMAMOTO Yuji <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>

I'll send a PR after rust-lang/libc#1622 is merged and released

The new version of libc contains changes necessary to build wasmer-runtime-core for Android. See rust-lang/libc#1622 for details.

1292: Experimental Support for Android (x86_64 and AArch64) r=syrusakbary a=igrep # Description Related: #1113 # Current Status - ~~This pull request is a draft until the next version of libc crate (which should contain rust-lang/libc#1622 - Now released! 🎉 - I confirmed the tests of wasmer-runtime-core pass on Android x86\_64. - The other tests including ones on AArch64 seems too hard so far... 😓 # Review - [x] Add a short description of the the change to the CHANGELOG.md file # Note I'm happy given any hint to test of Android specific code (esp. in libc I added in rust-lang/libc#1622). Co-authored-by: Yuji Yamamoto <[email protected]> Co-authored-by: YAMAMOTO Yuji <[email protected]> Co-authored-by: Mark McCaskey <[email protected]>

rust-highfive assigned gnzlbg Dec 12, 2019

igrep force-pushed the android-ucontext branch 3 times, most recently from e3c5916 to c6b0b73 Compare December 19, 2019 01:47

igrep force-pushed the android-ucontext branch from c6b0b73 to 3d87ca1 Compare December 20, 2019 01:39

gnzlbg reviewed Dec 23, 2019

View reviewed changes

igrep commented Dec 26, 2019

View reviewed changes

src/unix/linux_like/android/b32/arm.rs Show resolved Hide resolved

igrep pushed a commit to igrep/wasmer that referenced this pull request Dec 27, 2019

Support Android

667d221

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep pushed a commit to igrep/wasmer that referenced this pull request Dec 27, 2019

Support Android

965dff0

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep pushed a commit to igrep/wasmer that referenced this pull request Dec 27, 2019

Support Android

3214dec

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep force-pushed the android-ucontext branch from 3183d29 to d9feee2 Compare January 14, 2020 03:28

igrep pushed a commit to igrep/wasmer that referenced this pull request Jan 21, 2020

Support Android

a95734d

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep pushed a commit to iijlab/wasmonandroid that referenced this pull request Jan 21, 2020

Rebased PR to libc

5c9d7a0

rust-lang/libc#1622

igrep pushed a commit to igrep/wasmer that referenced this pull request Jan 31, 2020

Support Android

f70f899

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep force-pushed the android-ucontext branch from d9feee2 to 322a02d Compare February 19, 2020 01:10

rust-highfive assigned JohnTitor and unassigned gnzlbg Feb 25, 2020

JohnTitor reviewed Feb 28, 2020

View reviewed changes

src/unix/linux_like/android/b32/arm.rs Outdated Show resolved Hide resolved

Yuji Yamamoto added 4 commits February 28, 2020 15:50

Add definitions in ucontext.h in Android for ARM

10fcecf

Ref: https://android.googlesource.com/platform/bionic/+/refs/tags/ndk-r20/libc/include/sys/ucontext.h

Add definitions in ucontext.h in Android for x86

fa543d1

Ref: https://android.googlesource.com/platform/bionic/+/refs/tags/ndk-r20/libc/include/sys/ucontext.h

Add definitions in ucontext.h in Android for x86_64

b03f713

Ref: https://android.googlesource.com/platform/bionic/+/refs/tags/ndk-r20/libc/include/sys/ucontext.h

Add ucontext.h to test target

338dd7c

igrep force-pushed the android-ucontext branch from 322a02d to 338dd7c Compare February 28, 2020 07:00

JohnTitor approved these changes Feb 29, 2020

View reviewed changes

JohnTitor merged commit 70d4c56 into rust-lang:master Feb 29, 2020

igrep pushed a commit to igrep/wasmer that referenced this pull request Mar 2, 2020

Support Android

b4bcf92

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep deleted the android-ucontext branch March 2, 2020 06:50

igrep mentioned this pull request Mar 2, 2020

Seeking to Compile for Realtime Graphics on Mobile VR (Android) Devices, Please Advise wasmerio/wasmer#1113

Closed

igrep pushed a commit to igrep/wasmer that referenced this pull request Mar 3, 2020

Support Android

be6e879

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep pushed a commit to igrep/wasmer that referenced this pull request Mar 11, 2020

Support Android

49a9e35

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep pushed a commit to igrep/wasmer that referenced this pull request Mar 11, 2020

Support Android

9c8f8b5

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep pushed a commit to igrep/wasmer that referenced this pull request Mar 12, 2020

Support Android

06a6602

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep mentioned this pull request Mar 12, 2020

Experimental Support for Android (x86_64 and AArch64) wasmerio/wasmer#1292

Merged

1 task

igrep pushed a commit to igrep/wasmer that referenced this pull request Mar 16, 2020

Support Android

5991f69

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep pushed a commit to igrep/wasmer that referenced this pull request Mar 18, 2020

Support Android

66d1a8c

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep pushed a commit to igrep/wasmer that referenced this pull request Mar 18, 2020

Update libc

d3e50c5

The new version of libc contains changes necessary to build wasmer-runtime-core for Android. See rust-lang/libc#1622 for details.

igrep pushed a commit to igrep/wasmer that referenced this pull request Mar 19, 2020

Support Android

21156a4

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep pushed a commit to igrep/wasmer that referenced this pull request Mar 19, 2020

Update libc

be3a023

The new version of libc contains changes necessary to build wasmer-runtime-core for Android. See rust-lang/libc#1622 for details.

igrep pushed a commit to igrep/wasmer that referenced this pull request Mar 23, 2020

Support Android

0df0a1c

I'll send a PR after rust-lang/libc#1622 is merged and released

igrep pushed a commit to igrep/wasmer that referenced this pull request Mar 23, 2020

Update libc

96a0f85

The new version of libc contains changes necessary to build wasmer-runtime-core for Android. See rust-lang/libc#1622 for details.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add definitions in ucontext.h in Android for ARM, x86, and x86_64 #1622

Add definitions in ucontext.h in Android for ARM, x86, and x86_64 #1622

igrep commented Dec 12, 2019

rust-highfive commented Dec 12, 2019

igrep commented Dec 19, 2019

gnzlbg left a comment

igrep commented Dec 24, 2019

gnzlbg commented Dec 24, 2019

igrep commented Jan 16, 2020

igrep commented Jan 30, 2020

igrep commented Feb 19, 2020

JohnTitor commented Feb 25, 2020

JohnTitor left a comment

JohnTitor left a comment

Add definitions in ucontext.h in Android for ARM, x86, and x86_64 #1622

Add definitions in ucontext.h in Android for ARM, x86, and x86_64 #1622

Conversation

igrep commented Dec 12, 2019

rust-highfive commented Dec 12, 2019

igrep commented Dec 19, 2019

gnzlbg left a comment

Choose a reason for hiding this comment

igrep commented Dec 24, 2019

gnzlbg commented Dec 24, 2019

igrep commented Jan 16, 2020

igrep commented Jan 30, 2020

igrep commented Feb 19, 2020

JohnTitor commented Feb 25, 2020

JohnTitor left a comment

Choose a reason for hiding this comment

JohnTitor left a comment

Choose a reason for hiding this comment