Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hexagon-unknown-linux-musl #1443

Merged
merged 1 commit into from
Jul 27, 2019

Conversation

androm3da
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 27, 2019

@bors: r+

LGTM. Do you know if qemu supports hexagon ? If so, it might be worth it to try to set up a docker container that runs libc tests for this target under qemu-user like we do for the other targets.

@bors
Copy link
Contributor

bors commented Jul 27, 2019

📌 Commit 214d32d has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Jul 27, 2019

⌛ Testing commit 214d32d with merge a9b130b...

bors added a commit that referenced this pull request Jul 27, 2019
Add support for hexagon-unknown-linux-musl
@bors
Copy link
Contributor

bors commented Jul 27, 2019

💔 Test failed - checks-travis

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 27, 2019

@bors: retry

bors added a commit that referenced this pull request Jul 27, 2019
Add support for hexagon-unknown-linux-musl
@bors
Copy link
Contributor

bors commented Jul 27, 2019

⌛ Testing commit 214d32d with merge 2b01f7e...

@bors
Copy link
Contributor

bors commented Jul 27, 2019

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 2b01f7e to master...

@bors bors merged commit 214d32d into rust-lang:master Jul 27, 2019
@androm3da
Copy link
Contributor Author

@bors: r+

LGTM. Do you know if qemu supports hexagon ? If so, it might be worth it to try to set up a docker container that runs libc tests for this target under qemu-user like we do for the other targets.

No upstream support yet but we'll be working on that soon. Once it's present there we can add it.

Do you know how the qemu package(s) are installed for the CI? Does it just use the distro release of qemu? I ask because it would probably take quite a while after upstreaming before we saw it in an Ubuntu/Debian release.

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 27, 2019

Do you know how the qemu package(s) are installed for the CI? Does it just use the distro release of qemu? I ask because it would probably take quite a while after upstreaming before we saw it in an Ubuntu/Debian release.

I think we could just install the latest released qemu from a third-party repository, at least, until the required qemu version starts being shipped by the distro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants