Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approve changes to the COPYRIGHT notices shipped with Rust #120

Closed
jonathanpallant opened this issue Nov 29, 2024 · 7 comments
Closed

Approve changes to the COPYRIGHT notices shipped with Rust #120

jonathanpallant opened this issue Nov 29, 2024 · 7 comments
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-council-nominated This issue nominated for discussion in a meeting. T-leadership-council Team: Leadership Coucil to-announce Issue has finished its final comment period.

Comments

@jonathanpallant
Copy link

jonathanpallant commented Nov 29, 2024

I have been working on updating how Rust reports the copyright notices and licenses for its various constituent parts as part of my work on Ferrocene (because we need to make the same reports).

The PR is rust-lang/rust#133461

* Updates the `COPYRIGHT` file to describe how we actually do things now, and removes the licence text from it as they are stored elsewhere.
* dist tarballs get all of the files in `LICENSES/*`.
  * This folder is managed by `reuse` and each file exists because we refer to the licence somewhere in our tree. We should be supplying these licence texts to anyone who obtains a copy of the source code and now we do.
* The binary rust tarball gets `COPYRIGHT.html` and `COPYRIGHT-library.html`, which are auto-generated files that describe the licence information for both the in-tree source files used to build the Rust toolchain, and the out-of-tree dependencies we used to build the toolchain.
   * The other binary tarballs are unchanged, for now. In future you need to make a call whether to ship multiple version of COPYRIGHT.html, or whether to try and make, for example, a cargo-specific COPYRIGHT.html file.
* The `LICENSE-MIT` file now includes a blanket copyright statement, as the text indicates that it should and because users will expect to know who owns the copyright of the material they have been given (even if the answer is 'lots of people').

In other words, instead of the old COPYRIGHT file we will now ship all the reuse licenses and the new COPYRIGHT.html and COPYRIGHT-library.html files which are built by CI.

This is a non-trivial change because it:

  • changes how the license for the Rust toolchain is expressed, and
  • adds a 7MB HTML file to the binary distribution.

Asking infra to take a view on licensing matters seems slightly above their sign-off, and because this is a subject where People Have Strong Opinions and where being wrong can cost a lot of actual dollars, I wouldn't want it coming back on Infra for signing it off. I couldn't think of another team who have the appropriate sign-off authority here either.

So, I would like the Council to indicate to Infra whether would support the merging of this PR, or not. In preparing this PR I believe I am acting in accordance with the guidance supplied by the Rust Foundation and their legal team, but you shouldn't blindly trust me on that.

@jonathanpallant
Copy link
Author

The use of REUSE is covered by this MCP: rust-lang/compiler-team#519

Which has this tracking issue: rust-lang/rust#99414

@Mark-Simulacrum Mark-Simulacrum added the I-council-nominated This issue nominated for discussion in a meeting. label Nov 29, 2024
@ehuss ehuss added the T-leadership-council Team: Leadership Coucil label Dec 19, 2024
@ehuss
Copy link
Contributor

ehuss commented Dec 19, 2024

We checked in with the legal counsel regarding the MIT license. They said that the copyright statement is optional, but still useful, and they agreed with the proposal here.

@rust-lang/leadership-council, I'd like to propose to merge rust-lang/rust#133461. There is a link to a ZIP file at rust-lang/rust#133461 (comment) with what the new copyright files look like if you are interested in looking at them.

Since we don't have a process or clear owner or responsibility for this stuff, I'd like to just lean on the council to formally make a decision on this. Thus:

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Dec 19, 2024

Team member @ehuss has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 19, 2024
@traviscross
Copy link
Contributor

@rfcbot reviewed

Looks right to me.

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 20, 2024
@rfcbot
Copy link
Collaborator

rfcbot commented Dec 20, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Issue has finished its final comment period. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 30, 2024
@rfcbot
Copy link
Collaborator

rfcbot commented Dec 30, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-council-nominated This issue nominated for discussion in a meeting. T-leadership-council Team: Leadership Coucil to-announce Issue has finished its final comment period.
Projects
None yet
Development

No branches or pull requests

5 participants