Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for v0.15.0, bump cargo.toml #551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clarfonthey
Copy link
Contributor

Rather than just asking @Amanieu to do all this, I decided to help out a bit. Put some question marks in the date field that will need to be replaced once this is actually merged.

Will still need someone to do a proper release for this, but hopefully the changelog is good at least.

@clarfonthey
Copy link
Contributor Author

cc @Amanieu @cuviper I updated this to include everything that's been merged plus #556 since I figured you wanted to get that in before 0.15 too. Anything else that needs fixing before release?

- Added `borsh` feature with `BorshSerialize` and `BorshDeserialize` impls. (#525)
- Added `Assign` impls for `HashSet` operators. (#529)
- Added `Default` impls for iterator types. (#542)
- Added `RawTable::iter_hash` and `HashTable::iter_hash{,_mut}` methods. (#549)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to mention private RawTable.

Suggested change
- Added `RawTable::iter_hash` and `HashTable::iter_hash{,_mut}` methods. (#549)
- Added `HashTable::iter_hash{,_mut}` methods. (#549)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. 🤦🏻

- Added `Default` impls for iterator types. (#542)
- Added `RawTable::iter_hash` and `HashTable::iter_hash{,_mut}` methods. (#549)
- Added `Hash{Table,Map,Set}::allocation_size` methods. (#553)

### Changed

- Changed `hash_set::{Entry, VacantEntry}::insert` to return `OccupiedEntry`. (#495)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entry::insert only changed in its implementation, but already returned OccupiedEntry.

Suggested change
- Changed `hash_set::{Entry, VacantEntry}::insert` to return `OccupiedEntry`. (#495)
- Changed `hash_set::VacantEntry::insert` to return `OccupiedEntry`. (#495)

* Fixed typos, stray backticks in docs. (#558, #560)

### Removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `HashSet::get_or_insert_owned` has been removed in favor of `get_or_insert_with`. (#555)

@Amanieu
Copy link
Member

Amanieu commented Sep 20, 2024

With #561 and #556 merged we should be good to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants