Raw entry hasher #54
Merged
Raw entry hasher #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amanieu
reviewed
Mar 17, 2019
src/map.rs
Outdated
| S: BuildHasher, | ||
| H: Fn(&K) -> u64, | ||
| { | ||
| self.table.reserve(1, |x| hasher(&x.0)); |
There was a problem hiding this comment.
You don't actually need to call reserve here, it is done internally by insert. I realize now that the reserve call was unnecessary in the first place.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 17, 2019
54: Raw entry hasher r=Amanieu a=sujayakar This PR allows the user to create a `HashMap` where `K` doesn't implement `Hash`, so long as they are okay with only using the raw entry API. The first step is to move around some methods that didn't actually depend on `K: Hash`. Then, the only non-plumbing change was to defer the `.reserve(1)` call on `raw_entry_mut` to right before insertion. Then, we expose a new method `RawVacantEntryMut::insert_with_hasher` that takes in the custom hashing function and passes it in to `reserve` before inserting. @Amanieu do these API changes merit a version bump? I think we're only allowing these methods to be used on _more_ types, but let me know. Closes #44 Co-authored-by: Sujay Jayakar <[email protected]>
|
Thanks! A major version bump isn't needed since we are only relaxing trait bounds, not tightening them. |
Build succeeded
|
|
@Amanieu, do you think the recent build failures are related to this diff? It looks like some Travis misconfiguration, but I'm not sure. |
|
Oh, that's something else. It should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to create a
HashMapwhereKdoesn't implementHash, so long as they are okay with only using the raw entry API.The first step is to move around some methods that didn't actually depend on
K: Hash. Then, the only non-plumbing change was to defer the.reserve(1)call onraw_entry_mutto right before insertion. Then, we expose a new methodRawVacantEntryMut::insert_with_hasherthat takes in the custom hashing function and passes it in toreservebefore inserting.@Amanieu do these API changes merit a version bump? I think we're only allowing these methods to be used on more types, but let me know.
Closes #44