-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another attempt to reduce size_of<HashMap> #159
Merged
Merged
Commits on May 17, 2020
-
- `data` field is removed, instead the allocation layout is changed such that first element of control bytes start exactly at one past last element of data table. So we just use negative index to access data table without touching size field. - Rewritten `calculate_layout` to remove padding between two tables, its placed either at start or end of allocation if necessary.
Configuration menu - View commit details
-
Copy full SHA for cdca6fb - Browse repository at this point
Copy the full SHA cdca6fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fa183b - Browse repository at this point
Copy the full SHA 2fa183bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 850093a - Browse repository at this point
Copy the full SHA 850093aView commit details -
fix miri and clippy build errors
doing `ptr as usize as *mut _` does escape from miri analysis ``` ptr: NonNull::new_unchecked(ptr), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a potentially NULL pointer, but expected something that cannot possibly fail to be greater or equal to 1 ``` I am not sure if this is correct way to fix it.
Configuration menu - View commit details
-
Copy full SHA for 9a5fffc - Browse repository at this point
Copy the full SHA 9a5fffcView commit details
Commits on May 20, 2020
-
- Removed unnecessary padding at the end of `calculate_layout` - Put back old comments - Renamed some functions - Use `#[cfg(feature = "...")]` instead `#[allow(dead_code)]`
Configuration menu - View commit details
-
Copy full SHA for 8002c2c - Browse repository at this point
Copy the full SHA 8002c2cView commit details
Commits on May 21, 2020
-
- nightly version of calculate_layout was putting padding between two tables in some cases, fixed. Also added debug_assert! to check this. - use wrapping_sub() instead sub() in data_start() (empty RawTable returns buckets() == 1, crosses allocation bounds)
Configuration menu - View commit details
-
Copy full SHA for a58cdf4 - Browse repository at this point
Copy the full SHA a58cdf4View commit details
Commits on May 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 46328d8 - Browse repository at this point
Copy the full SHA 46328d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47c10e7 - Browse repository at this point
Copy the full SHA 47c10e7View commit details -
- Removed unnecessary code from nightly `calculate_layout` - Added comment for `Bucket::ptr` data member
Configuration menu - View commit details
-
Copy full SHA for 7027781 - Browse repository at this point
Copy the full SHA 7027781View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a59dd3 - Browse repository at this point
Copy the full SHA 5a59dd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b500a0a - Browse repository at this point
Copy the full SHA b500a0aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.