Skip to content

Conversation

@alexanderkjall
Copy link
Contributor

as the tempdir crate has been superseded by tempfile

@JohnTitor JohnTitor force-pushed the replace-tempdir-with-tempfile branch from 7c9c648 to e2274c5 Compare October 27, 2022 22:49
@JohnTitor
Copy link
Member

So, tempfile breaks our MSRV on CI, however it's not much important (IMO) and alternatively, we could do cargo check only on MSRV CI. It doesn't affect user code in general but the downside is that we couldn't ensure the behavior (though I don't think it's a major issue).

@thomcc
Copy link
Member

thomcc commented Oct 29, 2022

Yeah, I don't think test-only MSRV changes matter. It probably is worth checking that the crate compiles under MSRV for now (well, I don't feel that strongly here, but if we care about MSRV we should), but we don't need to run/build the tests.

@thomcc
Copy link
Member

thomcc commented Oct 29, 2022

(OTOH I also don't think it's particularly important to update a test-only dep, especially if it causes complexity elsewhere. So your call)

@JohnTitor
Copy link
Member

JohnTitor commented Nov 7, 2022

I'm going close in favor of #108 (comment), at least tempdir works fine for now. Let's revisit once we bump up MSRV, thanks for the PR anyway!

@JohnTitor JohnTitor closed this Nov 7, 2022
@alexanderkjall alexanderkjall deleted the replace-tempdir-with-tempfile branch December 6, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants