Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

ICE 28189 #11

Merged
merged 1 commit into from
Oct 23, 2015
Merged

ICE 28189 #11

merged 1 commit into from
Oct 23, 2015

Conversation

emoon
Copy link
Contributor

@emoon emoon commented Oct 23, 2015

No description provided.

@steveklabnik
Copy link
Member

Ah ha! our first success! Travis failed because this has been fixed in the meantime.

So that you get credit, I'm going to merge this anyway, and then remove it in another commit. Thanks so much! 🎊 🎉 💯

steveklabnik added a commit that referenced this pull request Oct 23, 2015
@steveklabnik steveklabnik merged commit 495af08 into rust-lang:master Oct 23, 2015
@emoon
Copy link
Contributor Author

emoon commented Oct 23, 2015

Ah!

I was wondering why it was actually failing travis but I got the ICE locally but then it makes sense :)

@ghost
Copy link

ghost commented Oct 23, 2015

and then remove it in another commit

But wait aren't you going to keep it in a separate category called regressions(which are supposed to never fail) ? What if it comes back? :)

@steveklabnik
Copy link
Member

That's why the tracking bug is moved to E-needs test. That is what should keep it from coming back, the bug isn't fixed until there's a regression test in place.

Though a category might be fun...

@ghost
Copy link

ghost commented Oct 23, 2015

Got it.
But I mean, you could make another dir into which you just move the ones that pass, and test.sh will (also) fail if any of those fail, this way work is not lost is commit history. Or something like that.

EDIT: or, I don't know how travis works, maybe you can have two test.sh files, one for regressions.

@emoon emoon deleted the ice-28189 branch October 25, 2015 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants