Skip to content

futures_util::stream::SelectAll::push should use &self. #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2021
+2 −2
Merged

futures_util::stream::SelectAll::push should use &self. #2293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions futures-util/src/stream/select_all.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ impl<St: Stream + Unpin> SelectAll<St> {
/// function will not call `poll` on the submitted stream. The caller must
/// ensure that `SelectAll::poll` is called in order to receive task
/// notifications.
pub fn push(&mut self, stream: St) {
pub fn push(&self, stream: St) {
self.inner.push(stream.into_future());
}
}
Expand Down Expand Up @@ -118,7 +118,7 @@ pub fn select_all<I>(streams: I) -> SelectAll<I::Item>
where I: IntoIterator,
I::Item: Stream + Unpin
{
let mut set = SelectAll::new();
let set = SelectAll::new();

for stream in streams {
set.push(stream);
Expand Down