Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uses of try_ready! macro #1572

Merged
merged 1 commit into from
May 2, 2019
Merged

Remove uses of try_ready! macro #1572

merged 1 commit into from
May 2, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Apr 28, 2019 •
edited
Loading

try_ready!(..) is equivalent to ready!(..)? and ready!(..?), but the alternatives are shorter.

(Also, ready!(..)? is actually more powerful because it can handle Poll<Option<Result>>.)

@taiki-e taiki-e force-pushed the try_ready branch 2 times, most recently from 74fb505 to 87c7e27 Compare April 28, 2019 13:44
@taiki-e taiki-e changed the title Remove use of try_ready! macro Remove usages of try_ready! macro Apr 29, 2019
@taiki-e taiki-e changed the title Remove usages of try_ready! macro Remove uses of try_ready! macro Apr 30, 2019
@cramertj cramertj merged commit bd8dafa into rust-lang:master May 2, 2019
@taiki-e taiki-e deleted the try_ready branch May 3, 2019 00:40
@taiki-e taiki-e mentioned this pull request May 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @cramertj