Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zlib-rs to 0.3.0 to get multiple bugfixes #428

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

Shnatsel
Copy link
Member

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Could you also add GitHub links (essentially the body of the PR) into the commit?

Cargo.toml Show resolved Hide resolved
@Shnatsel
Copy link
Member Author

I believe the merge commit would have PR description as the commit message anyway. But sure, done.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this should do it.

If merge-commits would come up in code-lens or similar tools, that should be enough as well. I am not sure they do though.

Would you consider applying the suggestion? Once again I am too afraid to do it myself as it might prevent merging 😅.

Cargo.toml Outdated Show resolved Hide resolved
@folkertdev
Copy link
Contributor

also if you actually want to use this, it makes sense to bump the flate2 version too, see e.g. https://github.com/rust-lang/flate2-rs/pull/415/files

Co-authored-by: Sebastian Thiel <[email protected]>
@Shnatsel
Copy link
Member Author

I assume @Byron will bump it as part of the usual release process. If not, I'm happy to increment that number, sure.

@Byron
Copy link
Member

Byron commented Sep 26, 2024

Actually, changing the version number will make a release more straightforward. It's a bit like being a genie, limitless power, but impossible to use for yourself :D.

@Shnatsel
Copy link
Member Author

Version bumped

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Byron Byron merged commit 2c29780 into rust-lang:main Sep 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants