Change input argument to &str #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since input was converted to &str anyway there is no reason not to require it upfront. This also makes that API has more sense, since now it is obvious that "a slice of bytes that you want to be written out to somewhere" is an UTF-8 encoded string.
Expected data in tests is now a string slice, not a byte slice. Changed concat! macro in favour of r#"" strings.
Cleaned up say. Removed unnecessary intermediate Vecs. Added some comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed
inputto be&strinstead of&[u8]since it is more clear now what it does and the only thing that was done with it was converting it to&stranyway.Also cleaned up tests and "drawing" part of
sayfunction.