Introduce warning topbar menu, allow following crates to see warnings for #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless you're doing clean builds all the time, having optimized dependencies and reducing the debuginfo generated for them is faster because it makes the linker do less work.
This improves turnaround speed when locally testing changes that require rebuilding the docker image.
github-actions
bot
added
the
S-waiting-on-review
syphar
added
S-waiting-on-author
|
for progress this would need to be rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #2470, only the last commit is relevant currently
I still need to finish up work on grabbing data for the actual warnings, but I wanted some early feedback on the approach I'm taking to the UI, given this is the most client-side bit of UI we've got, @GuillaumeGomez.
Preview of what it looks like (with my wip warnings rendering too):