Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async registry_api & repository-stats updater #2334

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

syphar
Copy link
Member

@syphar syphar commented Nov 22, 2023

This refactors all usages of reqwest::blocking to async, also adding sqlx where necessary.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 22, 2023
@syphar
Copy link
Member Author

syphar commented Nov 22, 2023

@GuillaumeGomez the test failure in the gui tests looks odd, is that flaky? How could we prevent this? rebasing deleted the test failure from the logs, and I failed to copy it here.

@syphar syphar requested a review from a team as a code owner November 29, 2023 09:12
@syphar
Copy link
Member Author

syphar commented Dec 8, 2023

@rust-lang/docs-rs-reviewers here is another one, perhaps @GuillaumeGomez can help since I'm refactoring the repo-stats-updater ?

@GuillaumeGomez
Copy link
Member

Looks good to me. If the tests still pass, nothing else to add I suppose. ;)

@syphar syphar merged commit 863517b into rust-lang:master Dec 8, 2023
11 checks passed
@syphar syphar deleted the async-reqwest-sqlx branch December 8, 2023 14:17
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Dec 8, 2023
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants