Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position of source code pages sidebar #2332

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Nov 22, 2023

Fixes #2093.

I couldn't find where those rules were actually used. I tested a lot of crates but none of them used it. I suppose it was to fix a docs.rs bug we had at some point.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 22, 2023
@GuillaumeGomez GuillaumeGomez requested a review from a team November 29, 2023 14:34
@syphar
Copy link
Member

syphar commented Dec 1, 2023

@Nemo157 can you help with the review since it's frontend code? Otherwise I'll just test it as far as I can, and then merge :)

@GuillaumeGomez
Copy link
Member Author

The important thing to check is that it doesn't break for crates before and after the date of the CSS file. I used sysinfo as base for that since there are a lot of versions across time.

@GuillaumeGomez
Copy link
Member Author

Considering this is a bug fix, can we take a look in the next days please? We can do a call to have live explanations if you prefer.

@syphar
Copy link
Member

syphar commented Dec 15, 2023

Considering this is a bug fix, can we take a look in the next days please? We can do a call to have live explanations if you prefer.

I was hoping for some frontend help, but you're right in reminding me here.

I'll go the manual testing approach, if it works and fixes the issue, I'll approve.

Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the bug,
and that the fix resolves it.

Also, thank you for adding the test :)

@syphar syphar merged commit 975968c into rust-lang:master Dec 15, 2023
12 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Dec 15, 2023
@GuillaumeGomez GuillaumeGomez deleted the sidebar-pos branch December 15, 2023 14:28
@GuillaumeGomez
Copy link
Member Author

Thanks for the review!

@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken UI for sidebar on mobile
2 participants