-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix position of source code pages sidebar #2332
Conversation
@Nemo157 can you help with the review since it's frontend code? Otherwise I'll just test it as far as I can, and then merge :) |
The important thing to check is that it doesn't break for crates before and after the date of the CSS file. I used |
Considering this is a bug fix, can we take a look in the next days please? We can do a call to have live explanations if you prefer. |
I was hoping for some frontend help, but you're right in reminding me here. I'll go the manual testing approach, if it works and fixes the issue, I'll approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to reproduce the bug,
and that the fix resolves it.
Also, thank you for adding the test :)
Thanks for the review! |
Fixes #2093.
I couldn't find where those rules were actually used. I tested a lot of crates but none of them used it. I suppose it was to fix a docs.rs bug we had at some point.