replace schemamama with sqlx migrations #2327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops our schemamama migrations and replaces them with sqlx migrations, providing an initial migration file that represents just the current database schema.
Just running
database migrate
will also migrate the migration state, so updates should be seamless.I removed running the reverse migrations from the teardown for every test case, I assume it's good enough to clean the whole schema. I added a separate check in CI to test the full setup & teardown only once.
There is one case where this setup would break: when a developer has set
DATABASE_URL
and wants to runcargo run -- database migrate
it won't compile.sqlx migrate run
should work then. I wonder if we should update the documentation to usesqlx migrate run
, though this would mean that we need to install the sqlx CLI in more places.Also I would love some feedback on what documentation should be updated?