Don't cache the detected rustc-version, it's cheap enough to requery

[Nemo157]

Fixes the issue from #2296 (comment), running local builds still fails after updating the toolchain in a separate invocation because it does not attempt to detect the version.

[Nemo157]

(Waiting to check that the test fails before I push the fix, I can't run build tests locally at the moment)

[GuillaumeGomez]

Going to give it a try locally.

[GuillaumeGomez]

Still not working for me. Same error.

[syphar]

converting to draft until it works (coming from the comments, and the change itself that only adds tests :)

[GuillaumeGomez]

For the test, wouldn't it be better to have a new CI testsuite which starts the DB and then run the update toolchain command followed by generating docs for a specific crate to ensure it works?

[Nemo157]

converting to draft until it works (coming from the comments, and the change itself that only adds tests :)

Draft PRs don't have tests run on them

[Nemo157]

For the test, wouldn't it be better to have a new CI testsuite which starts the DB and then run the update toolchain command followed by generating docs for a specific crate to ensure it works?

That's a lot more maintenance work than having it run via the existing infrastructure. The test I have written using two separate RustwideBuilder instances should be equivalent, they don't share any relevant state through the Context.

[GuillaumeGomez]

The CI passed iirc and it doesn't work locally, so I'm not sure it's exactly the same.

[Nemo157]

CI build-tests was skipped, it's not meant to pass, this is just adding a test that should fail, I haven't pushed the fix for it.

[Nemo157]

Oh fun, out of disk space error (which shows as skipped instead of failed, which is a ✔️ because of GHA's weirdness about states).

[syphar]

converting to draft until it works (coming from the comments, and the change itself that only adds tests :)

Draft PRs don't have tests run on them

That would be new to me, and a thing I would fix.

Here's a draft PR with tests that are run: #2292

[Nemo157]

Ah, they aren't run with some configs. I had seen the CI/build result was skipped and assumed that was caused by the change to draft status, didn't notice it was out-of-disk till inspecting the second attempt.

[Nemo157]

... where is the button to mark as draft hiding

EDIT: Under reviewers of course, such an obvious place to hide it 🙃

[Nemo157]

Good, the test failed with the expected error message: https://github.com/rust-lang/docs.rs/actions/runs/6811549892/job/18522282940?pr=2306

[GuillaumeGomez]

🎉