Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't reverse change order when handling crates.io index updates #2302

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

syphar
Copy link
Member

@syphar syphar commented Nov 8, 2023

Fixes #2295

While there are some improvements for more deterministic order in crates-index-diff now, they aren't needed to fix this because the changes were separate commits: https://github.com/rust-lang/crates.io-index/commits/master/dy/li/dylink

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 8, 2023
@syphar syphar requested a review from Byron November 8, 2023 11:36
@syphar syphar force-pushed the no-reverse-in-index-handling branch from 4522e78 to b07624a Compare November 8, 2023 11:38
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this should make the linked issue go away.
I'd also hope that the latest version of crates-index-diff can already be used to add even more determinism.

@syphar syphar merged commit 624628a into rust-lang:master Nov 8, 2023
7 checks passed
@syphar syphar deleted the no-reverse-in-index-handling branch November 8, 2023 13:19
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 8, 2023
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crate marked as yanked when both yanked and unyanked in one index-update
2 participants