-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sort by select-box for searching crate #2297
Conversation
From the screenshot it looks like a different text color is being used. I'm not sure if the existing CSS has handling for a |
67b5ade
to
20971eb
Compare
20971eb
to
3f37c6c
Compare
Thanks for the update! I'll try to review it by the end of the week. |
So currently it looks like this: With these changes: diff --git a/templates/style/_vars.scss b/templates/style/_vars.scss
index aa97be9d..f28a0c19 100644
--- a/templates/style/_vars.scss
+++ b/templates/style/_vars.scss
@@ -7,6 +7,7 @@ $font-family-mono: "Source Code Pro", Menlo, Monaco, Consolas, "DejaVu Sans Mono
// Sizes
$top-navbar-height: 32px; // height of the floating top navbar
+$search-result-right-left-padding: 1em; // Size of the right and left padding for the search results
// Pure compatible media queries
// usage:
diff --git a/templates/style/style.scss b/templates/style/style.scss
index 0f3d7f92..149a6789 100644
--- a/templates/style/style.scss
+++ b/templates/style/style.scss
@@ -244,6 +244,7 @@ div.landing {
#search-select-nav {
display: flex;
flex-direction: column;
+ padding: 1em $search-result-right-left-padding;
.item-end {
align-self: flex-end
@@ -282,7 +283,7 @@ div.recent-releases-container {
.release {
display: block;
border-bottom: 1px solid var(--color-border);
- padding: 0.4em 1em;
+ padding: 0.4em $search-result-right-left-padding;
color: var(--color-standard);
a { It now looks like this: Could you apply them please? |
No problem. |
Looks good to me, thanks! Let's wait for @Nemo157 to check if it looks good to them as well. |
This PR for #2152
The main features are:
In the end, I didn't find a good way to test it, so I built some packages locally, changed the drop-down options, and saw how the results returned compared to crates-io.
the finally look is: