Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate web::releases to sqlx, set up sqlx db pool for production #2288

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

syphar
Copy link
Member

@syphar syphar commented Oct 21, 2023

This migrates the first batch of handlers to sqlx / async database.
I introduced a second setting for the async pool size so be able to update the sizes depending on the errors or usage.

Generally I don't like having block_on in the test-case, I would prefer using tokio::test (or sqlx::test) for that, but that needs more refactoring.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 21, 2023
src/config.rs Show resolved Hide resolved
@syphar syphar merged commit 168a37f into rust-lang:master Oct 21, 2023
8 checks passed
@syphar syphar deleted the more-sqlx-only-simple-cases branch October 21, 2023 14:10
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 21, 2023
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants