-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CODEOWNERS, automatically manage waiting-for-author/review labels #2283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super cool!
799e088
to
332ec31
Compare
Based on the feedback I got I decided for a less intrusive way, and created a new team for reviewers: rust-lang/team#1107 When the team is merged & deployed, we can continue with this PR. |
Hm... thinking about this a little longer, I'm thinking about actually dropping the labels and the logic. The idea:
Incorporating the draft-status this would mean the only useful status label (for me personally) would be "waiting for deploy". Will revisit this when rust-lang/team#1107 is merged |
I'll merge as-is for now, the new GH team was merged. Potentially we could get rid of the labels and replace it with better searches. |
This would automatically set some of the labels I currently always manually test, and often forget to set (but then again rely on them being set :) )
First of all it would add a
CODEOWNERS
file so a review gets requested from @rust-lang/docs-rs . I would understand if this it too much noise for the team and we could also limit the reviewers.Also this would: