Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CODEOWNERS, automatically manage waiting-for-author/review labels #2283

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

syphar
Copy link
Member

@syphar syphar commented Oct 19, 2023

This would automatically set some of the labels I currently always manually test, and often forget to set (but then again rely on them being set :) )

First of all it would add a CODEOWNERS file so a review gets requested from @rust-lang/docs-rs . I would understand if this it too much noise for the team and we could also limit the reviewers.

Also this would:

  • set the "waiting for review" label when a review is requested
  • set the "waiting for author" (and remove "review") when changes are requested (a review with just a comment wouldn't do this)
  • remove both labels when the PR is approved.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 19, 2023
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool!

@syphar syphar added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. label Nov 4, 2023
@syphar
Copy link
Member Author

syphar commented Nov 4, 2023

Based on the feedback I got I decided for a less intrusive way, and created a new team for reviewers: rust-lang/team#1107

When the team is merged & deployed, we can continue with this PR.

@syphar syphar added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 4, 2023
@syphar
Copy link
Member Author

syphar commented Nov 5, 2023

Hm... thinking about this a little longer, I'm thinking about actually dropping the labels and the logic.

The idea:

  • "waiting for review" -> request review from docs-rs gh team
  • "waiting for author" -> when a review was sent

Incorporating the draft-status this would mean the only useful status label (for me personally) would be "waiting for deploy".

Will revisit this when rust-lang/team#1107 is merged

@syphar syphar removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Nov 28, 2023
@syphar
Copy link
Member Author

syphar commented Nov 28, 2023

I'll merge as-is for now, the new GH team was merged.

Potentially we could get rid of the labels and replace it with better searches.

@syphar syphar merged commit 55baa98 into rust-lang:master Nov 28, 2023
7 checks passed
@syphar syphar deleted the review-automation branch November 28, 2023 14:48
@github-actions github-actions bot added the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 28, 2023
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants