Build id for archive index #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
Nemo157
reviewed
Oct 14, 2023
syphar
force-pushed
the
build-id-for-archive-index
branch
from
5a38e86
to
fdafe07
Compare
syphar
force-pushed
the
build-id-for-archive-index
branch
from
fdafe07
to
b149054
Compare
|
@Nemo157 anything missing from your side? I'm happy to spend more time on this :) |
Nemo157
approved these changes
Oct 20, 2023
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on / includes the changes from #2274.
The basic idea is to include an additional identifier (the latest build ID) into the filename for local archive indexes.
Through this we will invalidate the local files when there is a new build available.
This will solve #2273 and through that solve rebuilds with the new infrastructure.