Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade toml to 0.8 #2235

Merged
merged 1 commit into from
Oct 3, 2023
Merged

upgrade toml to 0.8 #2235

merged 1 commit into from
Oct 3, 2023

Conversation

syphar
Copy link
Member

@syphar syphar commented Sep 27, 2023

One important breaking change is in the changelog:

Serialization and deserialization of tuple variants has changed from being an array to being a table with the key being the variant name and the value being the array

toml-rs/toml@toml-v0.7.8...toml-v0.8.0

I think that our usage of toml in web::crate_details should be fine with the change, I'm not 100% sure about our usage in the metadata crate.

I would love to have a second pair of eyes on the change.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Sep 27, 2023
@Nemo157
Copy link
Member

Nemo157 commented Oct 2, 2023

Should be fine, we're not using serde::Deserialize with toml on any enums so that change won't affect us.

@syphar syphar merged commit 5e035a3 into rust-lang:master Oct 3, 2023
7 checks passed
@syphar syphar deleted the upgrade-toml branch October 3, 2023 07:19
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 3, 2023
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants