Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate updating toolchain from adding essential files so they can have different retries #2232

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Separate updating toolchain from adding essential files so they can have different retries #2232

merged 2 commits into from
Oct 23, 2023

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Sep 22, 2023

fixes #2231

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Sep 22, 2023
syphar
syphar requested changes Sep 24, 2023
View reviewed changes
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change in general, one comment & the build-tests fail

src/docbuilder/rustwide_builder.rs Show resolved Hide resolved
@syphar syphar added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Sep 24, 2023
@Nemo157 Nemo157 force-pushed the lock-build-on-failure branch 2 times, most recently from 9c92c9a to 4f8eaf6 Compare October 13, 2023 11:24
@Nemo157 Nemo157 added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 14, 2023
@syphar syphar added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 14, 2023
@Nemo157 Nemo157 requested a review from syphar October 20, 2023 20:22
@syphar syphar added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 21, 2023
@syphar syphar merged commit c94d21c into rust-lang:master Oct 23, 2023
7 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 23, 2023
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 5, 2023
@Nemo157 Nemo157 deleted the lock-build-on-failure branch March 8, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syphar syphar syphar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Queue was not locked when building empty-library failed
2 participants
@Nemo157 @syphar