rewrite consistency check & make it execute fixes #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nemo157 |
github-actions
bot
added
the
S-waiting-on-review
syphar
commented
Jan 7, 2023
Nemo157
reviewed
Jan 9, 2023
syphar
force-pushed
the
fix-consistency-check
branch
from
117da99
to
9884ae5
Compare
|
@Nemo157 do you think you have time to review this? |
Nemo157
reviewed
Jan 25, 2023
Nemo157
approved these changes
Jan 25, 2023
syphar
force-pushed
the
fix-consistency-check
branch
from
9884ae5
to
2eda218
Compare
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1934 and partially this sentry issue.
Also we wanted to run this check for a long time.
The diff algo is replaced by
Itertools::merge_join_by, reading releases from the database usesItertools::group_by.