Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change error reporting for yank errors #1989

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

syphar
Copy link
Member

@syphar syphar commented Jan 7, 2023

While digging into #1934 and the related sentry issue, I saw one thing:

after a build, we're already fetching the release-data from crates.io, and updating our release-record with the yank-status from the response.

let release_data = match self.index.api().get_release_data(name, version) {
Ok(data) => data,
Err(err) => {
warn!("{:#?}", err);
ReleaseData::default()
}
};

So this PR does:

  • change a warn to error when the crates.io data can't be fetched.
  • only log an error for the yank-state-update if we don't have a build queued, assuming the build will fix the yank-state

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jan 7, 2023
@syphar
Copy link
Member Author

syphar commented Jan 7, 2023

r? @Nemo157 @jyn514

@syphar syphar merged commit ba205ec into rust-lang:master Jan 22, 2023
@syphar syphar deleted the yank-while-queued branch January 22, 2023 19:36
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jan 22, 2023
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants