Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unauthenticated users to set basic status labels #1318

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Mar 13, 2021

More labels can be permitted later, but these labels are useful to
indicate the status of a PR. E.g., if someone addresses a review,
there should be a way for them to switch S-waiting-on-author to
S-waiting-on-review.

More labels can be permitted later, but these labels are useful to
indicate the status of a PR. E.g., if someone addresses a review,
there should be a way for them to switch `S-waiting-on-author` to
`S-waiting-on-review`.
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same comments as in rust-lang/rustc-dev-guide#910. I think

Should we also add an "auto-labeler" to add waiting-on-review to all PRs when opened?

is the only one that's actionable.

Thanks for the PR!

@camelid
Copy link
Member Author

camelid commented Mar 13, 2021

I have the same comments as in rust-lang/rustc-dev-guide#910. I think

Should we also add an "auto-labeler" to add waiting-on-review to all PRs when opened?

is the only one that's actionable.

Hmm, what do you mean? Is it necessary to add autolabeling before allowing unauthenticated users to change labels? Also, I think you would need to set up rust-highfive to get autolabeling.

@jyn514
Copy link
Member

jyn514 commented Mar 20, 2021

Is it necessary to add autolabeling before allowing unauthenticated users to change labels? Also, I think you would need to set up rust-highfive to get autolabeling.

Oh good point, I forgot the bots are separate. Wasn't there a plan to unify them at some point ... ?

@jyn514 jyn514 merged commit 4ee9d89 into rust-lang:master Mar 20, 2021
@camelid camelid deleted the triagebot branch March 20, 2021 20:53
@camelid
Copy link
Member Author

camelid commented Mar 20, 2021

Wasn't there a plan to unify them at some point ... ?

You might be thinking of rust-lang/triagebot#433, which IIRC is blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants