Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade git2 to fix compliation on nightly #3685

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

jtgeibel
Copy link
Member

@jtgeibel jtgeibel commented Jun 8, 2021

The compilation error is a known regression related to a soundness fix.
The latest git2 avoids the error. See also
rust-lang/rust#85574 (comment)

r? @Turbo87

The compilation error is a known regression related to a soundness fix.
The latest git2 avoid the error. See also
rust-lang/rust#85574 (comment)
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

feel free to r=me once CI has passed 👍

@Turbo87 Turbo87 added A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Jun 8, 2021
@jtgeibel
Copy link
Member Author

jtgeibel commented Jun 8, 2021

@bors r=Turbo87

@bors
Copy link
Contributor

bors commented Jun 8, 2021

📌 Commit ea78205 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Jun 8, 2021

⌛ Testing commit ea78205 with merge 6bfd2e4...

@bors
Copy link
Contributor

bors commented Jun 8, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing 6bfd2e4 to master...

@bors bors merged commit 6bfd2e4 into rust-lang:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants