Implement GET /crates/:crate_id/maintenance.svg endpoint
#2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sgrif (rust_highfive has picked a reviewer for you, use r? to override) |
Turbo87
force-pushed
the
maintenance-badge
branch
5 times, most recently
from
1725932
to
dcbe681
Compare
Turbo87
force-pushed
the
maintenance-badge
branch
from
dcbe681
to
9423034
Compare
|
r? @smarnach |
Turbo87
force-pushed
the
maintenance-badge
branch
from
9423034
to
10941b9
Compare
|
@smarnach any thoughts on this? :) |
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Sep 23, 2020
Remove some badges documentation. Badges have been removed from crates.io, so this updates the documentation. I don't think Cargo should manage a schema for the different services, and since crates.io isn't using these, I think it is mostly a dead feature. I left the `maintenance` field, because that might still have some meaning in the future. More details: * Removal from crates.io: rust-lang/crates.io#2436 rust-lang/crates.io#2440 * Solicited feedback for this change: https://internals.rust-lang.org/t/cargo-badges/12982 * Potential future support of `maintenance` status: rust-lang/crates.io#2437 rust-lang/crates.io#2438 rust-lang/crates.io#2439. It's not clear, if crates.io manages the status in the database, the motivation for putting it in `Cargo.toml` is probably pretty small.
|
reminder for myself: the weekly meeting decided to serve the SVGs ourselves instead of forwarding to shields.io |
Turbo87
force-pushed
the
maintenance-badge
branch
2 times, most recently
from
282d7f7
to
f771584
Compare
Turbo87
force-pushed
the
maintenance-badge
branch
from
f771584
to
99f0298
Compare
Turbo87
force-pushed
the
maintenance-badge
branch
from
99f0298
to
1fe81c3
Compare
|
☔ The latest upstream changes (presumably #2993) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2438
This will have to be revisited though when #2437 is being implemented.