Revert "Auto merge of #1715 - kzys:enable-fastboot, r=jtgeibel" #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ I've already rolled back the deploy in production, and this is purely a revert commit |
|
📌 Commit cef5879 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 5, 2019
Revert "Auto merge of #1715 - kzys:enable-fastboot, r=jtgeibel" This reverts commit 111b7eb, reversing changes made to 27bd9a8. This caused our memory usage to increase from 50MB to 350MB at boot, and I was able to trivially cause the server to run out of memory by hitting /policies repeatedly. This introduces a DOS vector that we can't afford.
Merged
|
☀️ Test successful - checks-travis |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 111b7eb, reversing
changes made to 27bd9a8.
This caused our memory usage to increase from 50MB to 350MB at boot, and
I was able to trivially cause the server to run out of memory by hitting
/policies repeatedly. This introduces a DOS vector that we can't afford.