Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest master for lettre and lettre_email #1754

Merged
merged 1 commit into from
May 29, 2019

Conversation

jtgeibel
Copy link
Member

This will fix our CI on the beta branch, which is currently failing due
to a known breaking inference change. See rust-lang/rust#60958 for
more info.

I have reviewed the upstream changes relative to our current version
and see no issues with the changes there (although we could
alternatively backport just the needed fix).

Copy link
Contributor

@sgrif sgrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Cargo.toml Outdated Show resolved Hide resolved
This will fix our CI on the beta branch, which is currently failing due
to a known breaking inference change.  See rust-lang/rust#60958 for
more info.

I have reviewed the [upstream changes] relative to our current version
and see no issues with the changes there (although we could
alternatively backport just the needed fix).

[upstream changes]: lettre/lettre@v0.9.0...0ead3cd
@jtgeibel
Copy link
Member Author

Are the double slashes intentional?

Nope, fixed.

@bors r+

@jtgeibel
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented May 29, 2019

📌 Commit aee48c1 has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented May 29, 2019

⌛ Testing commit aee48c1 with merge 687849c...

bors added a commit that referenced this pull request May 29, 2019
Update to latest master for lettre and lettre_email

This will fix our CI on the beta branch, which is currently failing due
to a known breaking inference change.  See rust-lang/rust#60958 for
more info.

I have reviewed the [upstream changes] relative to our current version
and see no issues with the changes there (although we could
alternatively backport just the needed fix).

[upstream changes]: lettre/lettre@v0.9.0...0ead3cd
@bors
Copy link
Contributor

bors commented May 29, 2019

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing 687849c to master...

@bors bors merged commit aee48c1 into rust-lang:master May 29, 2019
@jtgeibel jtgeibel deleted the update/lettre branch July 14, 2019 21:09
jtgeibel added a commit to jtgeibel/crates.io that referenced this pull request Jul 14, 2019
Also see rust-lang#1754 where this workaround was originally added.  The changes
were released upstream in version `0.9.2`.
bors added a commit that referenced this pull request Jul 16, 2019
Switch back to released versions of `lettre` and `lettre_email`

Also see #1754 where this workaround was originally added.  The changes
were released upstream in version `0.9.2`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants