Update tests to use hyper 0.12 #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtgeibel
changed the title
jtgeibel
force-pushed
the
update-tests-to-use-hyper-master
branch
from
b7419ff to
459cf01
Compare
|
I've rebased and switched over to the newly released hyper 0.12. |
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Jun 6, 2018
1394: Update tests to use hyper 0.12 r=sgrif This PR updates the HTTP recording test infrastructure to use hyper 0.12. The goal is to update hyper in the tests now to minimize any version changes when eventually moving production over to hyper (see companion PR #1378). While we don't *have* to use the same version of hyper in production and our tests, having different versions would regress compile times. Ignoring the crate additions/removals (as production code obviously don't depend on them), the only overlap I see with production is updating `libc` from 0.2.33 to 0.2.40. As far as I can tell, the following changes do not affect production, even transitively (and if they do, are minimal): * `net2` - 0.2.31 to 0.2.32 * `bytes` - 0.4.5 to 0.4.7 * `futures` - 0.1.17 to 0.1.21 * `tokio-core` - 0.1.12 to 0.1.17 * `tokio-io` - 0.1.3 to 0.1.6 It was necessary to lowercase the request header names in the recordings under `http-data` because the hyper client sending the request no longer uses title-case. [source]: https://twitter.com/seanmonstar/status/992156132411035648
Needed to run this to get tokio-core and hyper building
jtgeibel
force-pushed
the
update-tests-to-use-hyper-master
branch
from
459cf01 to
f625122
Compare
|
Bors failed to merge this because another merge hit master while CI was running on the bors staging branch. I've rebased on master and resolved the conflicts. |
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Jun 20, 2018
1394: Update tests to use hyper 0.12 r=jtgeibel This PR updates the HTTP recording test infrastructure to use hyper 0.12. The goal is to update hyper in the tests now to minimize any version changes when eventually moving production over to hyper (see companion PR #1378). While we don't *have* to use the same version of hyper in production and our tests, having different versions would regress compile times. Ignoring the crate additions/removals (as production code obviously don't depend on them), the only overlap I see with production is updating `libc` from 0.2.33 to 0.2.42. As far as I can tell, the following changes do not affect production, even transitively (and if they do, are minimal): * `net2` - 0.2.31 to 0.2.32 * `bytes` - 0.4.5 to 0.4.8 * `futures` - 0.1.17 to 0.1.21 * `tokio-core` - 0.1.12 to 0.1.17 * `tokio-io` - 0.1.3 to 0.1.6 It was necessary to lowercase the request header names in the recordings under `http-data` because the hyper client sending the request no longer uses title-case.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the HTTP recording test infrastructure to use hyper 0.12. The goal is to update hyper in the tests now to minimize any version changes when eventually moving production over to hyper (see companion PR #1378). While we don't have to use the same version of hyper in production and our tests, having different versions would regress compile times.
Ignoring the crate additions/removals (as production code obviously don't depend on them), the only overlap I see with production is updating
libcfrom 0.2.33 to 0.2.42. As far as I can tell, the following changes do not affect production, even transitively (and if they do, are minimal):net2- 0.2.31 to 0.2.32bytes- 0.4.5 to 0.4.8futures- 0.1.17 to 0.1.21tokio-core- 0.1.12 to 0.1.17tokio-io- 0.1.3 to 0.1.6It was necessary to lowercase the request header names in the recordings under
http-databecause the hyper client sending the request no longer uses title-case.